Skip to content

refactor(audience): remove redundant Required/Optional JSDoc (SDK-116) #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImmutableJeffrey merged 1 commit into from
Apr 14, 2026
Merged

refactor(audience): remove redundant Required/Optional JSDoc (SDK-116) #2852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions packages/audience/sdk/src/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,107 +15,73 @@ export const AudienceEvents = {
} as const;

export interface SignUpProperties {
/** Optional. */
method?: string;
}

export interface SignInProperties {
/** Optional. */
method?: string;
}

export interface WishlistAddProperties {
/** Required. */
gameId: string;
/** Optional. */
source?: string;
/** Optional. */
platform?: string;
}

export interface WishlistRemoveProperties {
/** Required. */
gameId: string;
}

export interface PurchaseProperties {
/** Required. */
currency: string;
/** Required. */
value: number;
/** Optional. */
itemId?: string;
/** Optional. */
itemName?: string;
/** Optional. */
quantity?: number;
/** Optional. */
transactionId?: string;
}

export interface GameLaunchProperties {
/** Optional. */
platform?: string;
/** Optional. */
version?: string;
/** Optional. */
buildId?: string;
}

export type ProgressionStatus = 'start' | 'complete' | 'fail';

export interface ProgressionProperties {
/** Required. */
status: ProgressionStatus;
/** Optional. */
world?: string;
/** Optional. */
level?: string;
/** Optional. */
stage?: string;
/** Optional. */
score?: number;
/** Optional. */
durationSec?: number;
}

export type ResourceFlow = 'sink' | 'source';

export interface ResourceProperties {
/** Required. */
flow: ResourceFlow;
/** Required. */
currency: string;
/** Required. */
amount: number;
/** Optional. */
itemType?: string;
/** Optional. */
itemId?: string;
}

export interface EmailAcquiredProperties {
/** Optional. */
source?: string;
}

export interface GamePageViewedProperties {
/** Required. */
gameId: string;
/** Optional. */
gameName?: string;
/** Optional. */
slug?: string;
}

export interface LinkClickedProperties {
/** Required. */
url: string;
/** Optional. */
label?: string;
/** Optional. */
source?: string;
/** Optional. */
gameId?: string;
}

Expand Down
Loading