feat(orderbook): Add createTraitBid, getTraitBid and listTraitBid functions for orderbook#2854
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit dba6215
☁️ Nx Cloud last updated this comment at |
JCSanPedro
changed the title
naveen-imtb
reviewed
Apr 15, 2026
| sell, | ||
| buy, | ||
| true, | ||
| orderStart || new Date(), |
Contributor
There was a problem hiding this comment.
In what scenario will the startDate be undefined? 🤔 Do we need to default it? Same with orderExpiry - Are they not mandatory fields?
Contributor
Author
There was a problem hiding this comment.
Yes they are mandatory fields for the API. If the caller of this SDK function doesn't define start and expiry values, then we opt to use sensible defaults here.
naveen-imtb
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi👋, please ensure the PR title follows the below standards:
type(scope): message. For example:feat(passport): my new feature!after thetype(scope), for examplefeat(passport)!: my new breaking featureSummary
Regenerates the orderbook api client, and adds
createTraitBid,getTraitBidandlistTraitBidsutility functions for working with trait bids for the orderbook sdk.Detail and impact of the change
Added
Changed
Deprecated
Removed
Fixed
Security
Anything else worth calling out?