feat(orderbook): Add support for creating metadata bids with criteria#2874
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit a2d80d9
☁️ Nx Cloud last updated this comment at |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a2d80d9. Configure here.
naveen-imtb
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi👋, please ensure the PR title follows the below standards:
type(scope): message. For example:feat(passport): my new feature!after thetype(scope), for examplefeat(passport)!: my new breaking featureSummary
Updates the parameters for creating metadata bids to allow specifying either a
metadata-idor a set of metadata criteria filters.Detail and impact of the change
Added
Changed
Deprecated
Removed
Fixed
Security
Anything else worth calling out?
Note
Medium Risk
Moderate risk: changes the public
CreateMetadataBidParamsshape and request payload for metadata bids, which could break callers and affect bid creation/mapping if criteria validation or mapping is incorrect.Overview
Adds support for creating metadata bids using either a single
metadataIdor a newmetadataCriteriaarray of field-level filters, enforcing mutual exclusivity and performing client-side validation of allowed field names, non-empty values, and duplicate filters.Extends the OpenAPI SDK types and mappers to handle
metadata_criteria(and optionalmetadata_id) in both request and response mapping, and updates unit + e2e tests to cover criteria-based creation and fulfillment paths.Reviewed by Cursor Bugbot for commit a2d80d9. Bugbot is set up for automated code reviews on this repo. Configure here.