Skip to content

feat(orderbook): Add support for creating metadata bids with criteria#2874

Merged
JCSanPedro merged 2 commits into
mainfrom
BLO-117-metadata-bid-extension-sdk
May 21, 2026
Merged

feat(orderbook): Add support for creating metadata bids with criteria#2874
JCSanPedro merged 2 commits into
mainfrom
BLO-117-metadata-bid-extension-sdk

Conversation

@JCSanPedro
Copy link
Copy Markdown
Contributor

@JCSanPedro JCSanPedro commented May 21, 2026

Hi👋, please ensure the PR title follows the below standards:

  • PR is titled with conventional commit style naming: type(scope): message. For example: feat(passport): my new feature
  • If you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities, add a ! after the type(scope), for example feat(passport)!: my new breaking feature

Summary

Updates the parameters for creating metadata bids to allow specifying either a metadata-id or a set of metadata criteria filters.

Detail and impact of the change

Added

Changed

  • Update orderbook
  • Update e2e tests for metadata bids with criteria

Deprecated

Removed

Fixed

Security

Anything else worth calling out?


Note

Medium Risk
Moderate risk: changes the public CreateMetadataBidParams shape and request payload for metadata bids, which could break callers and affect bid creation/mapping if criteria validation or mapping is incorrect.

Overview
Adds support for creating metadata bids using either a single metadataId or a new metadataCriteria array of field-level filters, enforcing mutual exclusivity and performing client-side validation of allowed field names, non-empty values, and duplicate filters.

Extends the OpenAPI SDK types and mappers to handle metadata_criteria (and optional metadata_id) in both request and response mapping, and updates unit + e2e tests to cover criteria-based creation and fulfillment paths.

Reviewed by Cursor Bugbot for commit a2d80d9. Bugbot is set up for automated code reviews on this repo. Configure here.

@JCSanPedro JCSanPedro requested a review from a team as a code owner May 21, 2026 05:12
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 21, 2026

View your CI Pipeline Execution ↗ for commit a2d80d9

Command Status Duration Result
nx affected -t build,lint,test ✅ Succeeded 2m 46s View ↗
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 1m 19s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-21 05:16:29 UTC

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a2d80d9. Configure here.

Comment thread packages/orderbook/src/api-client/api-client.ts
@JCSanPedro JCSanPedro added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 60a837f May 21, 2026
12 checks passed
@JCSanPedro JCSanPedro deleted the BLO-117-metadata-bid-extension-sdk branch May 21, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants