refactor(audience): SDK test pinning and sample-app custom events (SDK-277) #1597
Annotations
1 error and 2 warnings
|
commitlint
You have commit messages with errors
⧗ input: test(audience-sdk,sample): Unity-only DeviceCollector and UXML alignment drafts
Two Unity-only test fixtures the dotnet test runner cannot reach
(DeviceCollector depends on UnityEngine.SystemInfo / Application;
SampleAppUxml needs Unity test framework gating). Both run under the
Unity Test Framework once the project is opened in the editor.
DeviceCollectorTests (src/Packages/Audience/Tests/Editor/, excluded
from the headless dotnet build by Audience.Tests.csproj's
Compile Remove="Editor/**/*.cs" rule) pin DeviceCollector's emitted
key sets against GameLaunchPropertyKeys and ContextKeys, assert that
no unknown keys leak in either direction, and verify every
string-typed value is capped at Constants.MaxFieldLength.
SampleAppUxmlAlignmentTests (examples/audience/Assets/SampleApp/Tests/
Runtime/, gated by the existing UNITY_INCLUDE_TESTS define on the
SampleApp.Tests asmdef) reads Resources/AudienceSample.uxml as XML
and asserts every SampleAppUi name and Css constant that is
slug-shaped (lowercase / dashes / no spaces) appears as a name= or
class= attribute somewhere in the markup. Runtime-only CSS toggles
(state-warn, copied, narrow, has-value, etc.) are filtered by the
slug-shape heuristic so the test only flags constants that look like
they should map directly to UXML.
Both files compile cleanly. They will not run under dotnet test.
Run them via Unity Test Runner.
Follow-up to SDK-272 (centralisation of duplicated literals).
✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
|
|
commitlint
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v3. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
commitlint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|