Skip to content

Commit 2d03ea7

Browse files
ci(audience): fix apostrophe in docker bash heredoc comment
Commit e7718f6 added a comment block above the xvfb-run line that contained 'xvfb's own screen size'. The apostrophe terminated the outer bash -c '...' single-quoted heredoc, the rest of the inner script became outer-shell tokens, and every Linux PlayMode cell on PR #765 exited 1 right after license activation (cell time 90 seconds). Rewords the comment without the apostrophe. No semantic change to the docker invocation or the Unity command line.
1 parent e7718f6 commit 2d03ea7

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

.github/workflows/test-audience-sample-app.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -541,14 +541,15 @@ jobs:
541541
log=/github/workspace/artifacts/playmode.log
542542
543543
# The player renders at 320x240 (Unity -screen-width and
544-
# -screen-height below). xvfb's own screen size does not
545-
# affect fragment fill because Unity creates its own GL
546-
# context at the requested window size. xvfb-run with -a
547-
# picks an unused display number and uses its default
548-
# screen geometry; the X11 extension flags below are the
549-
# only --server-args we actually need. Earlier comments
550-
# in this file claimed the xvfb -screen flag was the
551-
# source of the per-frame fill reduction; it was not.
544+
# -screen-height below). The xvfb desktop size does not
545+
# affect fragment fill because Unity creates a GL context
546+
# at the requested window size, regardless of how big the
547+
# underlying X desktop is. xvfb-run with -a picks an
548+
# unused display number and uses a default screen
549+
# geometry; the X11 extension flags below are the only
550+
# --server-args we actually need. Earlier comments in
551+
# this file claimed the xvfb -screen flag was the source
552+
# of the per-frame fill reduction; it was not.
552553
# UI Toolkit lays out fine because tests assert on the
553554
# VisualElement tree, not on rendered pixels.
554555
#

0 commit comments

Comments
 (0)