Commit 4d9a79d
refactor(audience): return Task from DeleteData (SDK-147)
DeleteData fires a backend DELETE for GDPR erasure but returned void,
so callers had no handle to know when the erasure completed or
failed. FlushAsync returns Task for the same reason - symmetrising
the lifecycle methods on the singleton.
- Public signature becomes `public static Task DeleteData(string
userId = null)`.
- All early-return paths (not initialised, no config, no anonymousId)
return Task.CompletedTask.
- The hot path's Task.Run is just returned directly instead of
discarded. No change to the actual HTTP request, error surfacing,
or anonymousId-file-side-effect-avoidance contract.
- Callers that want fire-and-forget still get it by ignoring the
return value; callers that want to gate on completion can now
await. Existing void-discarding call sites continue to compile.
Two new tests: awaited task completes after DELETE dispatch, and
the pre-Init guard returns Task.CompletedTask. 158 passing.
Linear: SDK-147
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 47f9605 commit 4d9a79d
2 files changed
Lines changed: 38 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
231 | | - | |
232 | | - | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
233 | 235 | | |
234 | | - | |
| 236 | + | |
235 | 237 | | |
236 | 238 | | |
237 | 239 | | |
238 | | - | |
| 240 | + | |
239 | 241 | | |
240 | 242 | | |
241 | 243 | | |
| |||
247 | 249 | | |
248 | 250 | | |
249 | 251 | | |
250 | | - | |
| 252 | + | |
251 | 253 | | |
252 | 254 | | |
253 | 255 | | |
254 | 256 | | |
255 | 257 | | |
256 | 258 | | |
257 | 259 | | |
258 | | - | |
| 260 | + | |
259 | 261 | | |
260 | 262 | | |
261 | 263 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
144 | 145 | | |
145 | 146 | | |
146 | 147 | | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
147 | 177 | | |
148 | 178 | | |
149 | 179 | | |
| |||
0 commit comments