Skip to content

Commit 6f7f276

Browse files
test(audience-sdk): pin Constants.LibraryName against package.json name
ConstantsTests already pinned Constants.LibraryVersion against the package.json "version" field so the two cannot silently drift; the matching pin for Constants.LibraryName ("com.immutable.audience") and package.json "name" was missing. Both feed context.library / context.libraryVersion on every outgoing event, so a rename of either side without the other would silently miscategorise events on the backend. Add a sibling LibraryName_MatchesPackageJson test that walks up to the same package.json and asserts the two strings match. Reuses the existing ReadPackageJson helper. Follow-up to SDK-272 (centralisation of duplicated literals).
1 parent 427f963 commit 6f7f276

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

src/Packages/Audience/Tests/Runtime/ConstantsTests.cs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,20 @@ public void LibraryVersion_MatchesPackageJson()
6969
"Constants.LibraryVersion must match package.json version");
7070
}
7171

72+
[Test]
73+
public void LibraryName_MatchesPackageJson()
74+
{
75+
// Same idea as LibraryVersion: fails the build if
76+
// Constants.LibraryName drifts from package.json "name".
77+
var packageJson = ReadPackageJson();
78+
var parsed = JsonReader.DeserializeObject(packageJson);
79+
80+
Assert.IsTrue(parsed.TryGetValue("name", out var nameObj),
81+
"package.json is missing a \"name\" field");
82+
Assert.AreEqual(Constants.LibraryName, nameObj,
83+
"Constants.LibraryName must match package.json name");
84+
}
85+
7286
private static string ReadPackageJson()
7387
{
7488
// Walk up from the test binary location looking for the Audience

0 commit comments

Comments
 (0)