ci(audience): add Editor-tests workflow + close test-discovery gap (SDK-326)

Audience package's Unity-dependent tests have never run in CI:
test-audience-sdk.yml's csproj excludes Tests/Runtime/Unity/** and
Tests/Editor/**, and test-audience-sample-app.yml never discovered the
package's tests because manifest.json had no testables entry.
DeviceCollectorTests has shipped with two compile errors that no PR
caught.

* Add testables entry — sample app workflow now picks up
  Immutable.Audience.Runtime.Tests via its existing PlayMode cells
  (StandaloneOSX/Win64), which also gives them IL2CPP coverage.
* New test-audience-sdk-editor.yml — runs Immutable.Audience.Editor.Tests
  (e.g. iOSInfoPlistPostProcessor). Editor-only asmdef + UnityEditor.iOS.Xcode
  dependency means it can't run in the sample app's PlayMode cells.
* Add InternalsVisibleTo on Immutable.Audience.Unity for the test asmdef
  so DeviceCollectorTests can see DeviceCollector and IDFVBridge.
* Fix DeviceCollectorTests' is-not-string-s pattern: the negated form
  doesn't bind s, so CS0165 fires once compilation actually runs.

Author: nattb8

.github/workflows/test-audience-sdk-editor.yml

@@ -0,0 +1,57 @@
+name: Audience package — Editor Tests
+
+# Runs Immutable.Audience.Editor.Tests (e.g. iOSInfoPlistPostProcessor).
+# Editor-only asmdef + UnityEditor.iOS.Xcode dependency means it can't run
+# in test-audience-sample-app.yml's StandaloneOSX/Win64 PlayMode cells.
+# Runtime.Tests are covered there via the manifest.json testables entry.
+
+on:
+  push:
+    branches: [main]
+    paths:
+      - 'src/Packages/Audience/**'
+      - 'examples/audience/Packages/manifest.json'
+      - '.github/workflows/test-audience-sdk-editor.yml'
+  pull_request:
+    paths:
+      - 'src/Packages/Audience/**'
+      - 'examples/audience/Packages/manifest.json'
+      - '.github/workflows/test-audience-sdk-editor.yml'
+
+jobs:
+  editmode:
+    if: github.event.pull_request.head.repo.fork == false || github.event_name == 'workflow_dispatch'
+    name: EditMode (Unity 2022.3 / iOS module)
+    runs-on: ubuntu-latest-8-cores
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          lfs: true
+
+      - uses: actions/cache@v4
+        with:
+          path: examples/audience/Library
+          key: Library-audience-editor-tests-${{ hashFiles('examples/audience/Packages/**', 'examples/audience/ProjectSettings/**', 'src/Packages/Audience/**') }}
+          restore-keys: |
+            Library-audience-editor-tests-
+
+      - uses: game-ci/unity-test-runner@v4
+        env:
+          UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }}
+          UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }}
+          UNITY_SERIAL: ${{ secrets.UNITY_SERIAL }}
+        with:
+          unityVersion: 2022.3.62f2
+          targetPlatform: iOS
+          projectPath: examples/audience
+          testMode: editmode
+          customParameters: -assemblyNames Immutable.Audience.Editor.Tests
+          checkName: Audience Editor Tests
+          artifactsPath: artifacts
+
+      - uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: audience-editor-test-results
+          path: artifacts

examples/audience/Packages/manifest.json

@@ -37,5 +37,8 @@
     "com.unity.modules.vr": "1.0.0",
     "com.unity.modules.wind": "1.0.0",
     "com.unity.modules.xr": "1.0.0"
-  }
+  },
+  "testables": [
+    "com.immutable.audience"
+  ]
 }

src/Packages/Audience/Runtime/Unity/AssemblyInfo.cs

@@ -0,0 +1,3 @@
+using System.Runtime.CompilerServices;
+
+[assembly: InternalsVisibleTo("Immutable.Audience.Runtime.Tests")]

src/Packages/Audience/Runtime/Unity/AssemblyInfo.cs.meta

@@ -15,20 +15,34 @@ internal class ImmutableAudienceTests
     {
         private string _testDir;
 
+        // AudienceUnityHooks.Install installs these at SubsystemRegistration
+        // (once per Unity process). The fixture has tests that overwrite them
+        // mid-test, so capture+restore around each test instead of nulling —
+        // nulling breaks downstream test fixtures sharing the same Unity
+        // process (e.g. the sample app PlayMode tests, which assume the
+        // default persistentDataPath provider stays installed).
+        private System.Func<string> _origDefaultPersistentDataPathProvider;
+        private System.Func<System.Collections.Generic.IReadOnlyDictionary<string, object>> _origLaunchContextProvider;
+        private System.Func<System.Collections.Generic.IReadOnlyDictionary<string, object>> _origContextProvider;
+
         [SetUp]
         public void SetUp()
         {
             _testDir = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
             Directory.CreateDirectory(_testDir);
+
+            _origDefaultPersistentDataPathProvider = ImmutableAudience.DefaultPersistentDataPathProvider;
+            _origLaunchContextProvider = ImmutableAudience.LaunchContextProvider;
+            _origContextProvider = ImmutableAudience.ContextProvider;
         }
 
         [TearDown]
         public void TearDown()
         {
             ImmutableAudience.ResetState();
-            ImmutableAudience.LaunchContextProvider = null;
-            ImmutableAudience.ContextProvider = null;
-            ImmutableAudience.DefaultPersistentDataPathProvider = null;
+            ImmutableAudience.LaunchContextProvider = _origLaunchContextProvider;
+            ImmutableAudience.ContextProvider = _origContextProvider;
+            ImmutableAudience.DefaultPersistentDataPathProvider = _origDefaultPersistentDataPathProvider;
             Identity.Reset(_testDir);
             if (Directory.Exists(_testDir))
                 Directory.Delete(_testDir, recursive: true);

src/Packages/Audience/Tests/Runtime/ImmutableAudienceTests.cs

@@ -25,9 +25,6 @@ public void SetUp()
         public void TearDown()
         {
             ImmutableAudience.ResetState();
-            ImmutableAudience.LaunchContextProvider = null;
-            ImmutableAudience.ContextProvider = null;
-            ImmutableAudience.DefaultPersistentDataPathProvider = null;
             Identity.Reset(_testDir);
             // Restore queue dir (a test may have left it as a file).
             var queueDir = AudiencePaths.QueueDir(_testDir);

src/Packages/Audience/Tests/Runtime/OfflineResilienceTests.cs

@@ -26,9 +26,6 @@ public void SetUp()
         public void TearDown()
         {
             ImmutableAudience.ResetState();
-            ImmutableAudience.LaunchContextProvider = null;
-            ImmutableAudience.ContextProvider = null;
-            ImmutableAudience.DefaultPersistentDataPathProvider = null;
             Identity.Reset(_testDir);
             if (Directory.Exists(_testDir))
                 Directory.Delete(_testDir, recursive: true);

src/Packages/Audience/Tests/Runtime/PublishableKeyPrefixTests.cs

@@ -27,9 +27,6 @@ public void SetUp()
         public void TearDown()
         {
             ImmutableAudience.ResetState();
-            ImmutableAudience.LaunchContextProvider = null;
-            ImmutableAudience.ContextProvider = null;
-            ImmutableAudience.DefaultPersistentDataPathProvider = null;
             Identity.Reset(_testDir);
             if (Directory.Exists(_testDir))
                 Directory.Delete(_testDir, recursive: true);

src/Packages/Audience/Tests/Runtime/ThreadSafetyStressTests.cs

@@ -68,7 +68,8 @@ public void CollectGameLaunchProperties_StringFields_DoNotExceed256Chars()
                 "platform", "version", "buildGuid", "unityVersion",
                 "osFamily", "deviceModel", "gpu", "gpuVendor", "cpu" })
             {
-                if (!props.TryGetValue(key, out var val) || val is not string s) continue;
+                if (!props.TryGetValue(key, out var val)) continue;
+                if (val is not string s) continue;
                 Assert.LessOrEqual(s.Length, 256, $"props[{key}] exceeds 256 chars");
             }
         }