fix(windows): make login resilient to missing protocol dialog

Author: rodrigo-fournier-immutable

sample/Tests/test/test_windows.py

@@ -120,7 +120,9 @@ def _perform_login(self):
             bring_sample_app_to_foreground()
 
             # Wait for authenticated screen
-            self.get_altdriver().wait_for_current_scene_to_be("AuthenticatedScene")
+            # Default AltTester timeout for this command is ~20s; CI often needs longer,
+            # especially when the browser auto-handles the deep-link without a dialog.
+            self.get_altdriver().wait_for_current_scene_to_be("AuthenticatedScene", timeout=90)
             stop_browser()
             print("[SUCCESS] Login successful")
 
@@ -224,7 +226,7 @@ def test_6_relogin(self):
         self.get_altdriver().wait_for_object(By.NAME, "ReloginBtn").tap()
 
         # Wait for authenticated screen
-        self.get_altdriver().wait_for_current_scene_to_be("AuthenticatedScene")
+        self.get_altdriver().wait_for_current_scene_to_be("AuthenticatedScene", timeout=90)
         print("Re-logged in")
 
         # Get access token
@@ -251,7 +253,7 @@ def test_7_reconnect_connect_imx(self):
         self.get_altdriver().wait_for_object(By.NAME, "ReconnectBtn").tap()
 
         # Wait for authenticated screen
-        self.get_altdriver().wait_for_current_scene_to_be("AuthenticatedScene")
+        self.get_altdriver().wait_for_current_scene_to_be("AuthenticatedScene", timeout=90)
         print("Reconnected")
 
         # Get access token
@@ -304,7 +306,7 @@ def test_8_connect_imx(self):
         bring_sample_app_to_foreground()
 
         # Wait for authenticated screen
-        self.get_altdriver().wait_for_current_scene_to_be("AuthenticatedScene")
+        self.get_altdriver().wait_for_current_scene_to_be("AuthenticatedScene", timeout=90)
         print("Logged in and connected to IMX")
         stop_browser()
 

sample/Tests/test/test_windows_helpers.py

@@ -36,6 +36,49 @@
 sys.path.insert(0, str(Path(__file__).resolve().parent.parent / 'src'))
 from fetch_otp import EMAIL, fetch_code
 
+# Unity authentication success markers we can reliably detect from Player.log.
+_UNITY_AUTH_SUCCESS_MARKERS = [
+    "AuthenticatedScene",
+    "COMPLETE_LOGIN_PKCE",
+    "LoginPKCESuccess",
+    "HandleLoginPkceSuccess",
+    "authentication successful",
+    "logged in successfully",
+    "Passport token received",
+]
+
+
+def wait_for_authentication_success_in_unity_logs(timeout_seconds: int = 60) -> bool:
+    """
+    Best-effort wait for Unity to process the deep-link callback.
+
+    This is needed in CI because the browser may auto-handle the external protocol
+    without showing any permission dialog (especially if protocol association is set),
+    so Selenium won't have any button to click, but Unity will still authenticate.
+    """
+    import os
+
+    product_name = os.getenv("UNITY_APP_NAME", get_product_name())
+    log_path = os.path.join("C:\\Users\\WindowsBuildsdkServi\\AppData\\LocalLow\\Immutable", product_name, "Player.log")
+
+    print(f"Waiting up to {timeout_seconds}s for Unity auth success in Player.log...")
+    print(f"Monitoring Unity log: {log_path}")
+
+    for _ in range(max(1, int(timeout_seconds))):
+        try:
+            with open(log_path, 'r', encoding='utf-8', errors='ignore') as f:
+                content = f.read()
+                if any(marker in content for marker in _UNITY_AUTH_SUCCESS_MARKERS):
+                    print("Authentication success detected in Unity logs!")
+                    return True
+        except Exception:
+            # Log may not exist yet or be temporarily locked; retry.
+            pass
+        time.sleep(1)
+
+    print("No authentication success detected in Unity logs within timeout.")
+    return False
+
 # Add chrome.exe to environment variable
 # Download chrome driver and add to environment variable
 
@@ -538,6 +581,8 @@ def login():
     time.sleep(3)
 
     try:
+        current_url_lower = (driver.current_url or "").lower()
+
         # Check what's actually on the page
         buttons = driver.find_elements(By.TAG_NAME, "button")
         print(f"Found {len(buttons)} buttons on page:")
@@ -548,16 +593,29 @@ def login():
                     print(f"  Button {i}: '{text}'")
             except:
                 pass
-        
-        # Wait for the deep link dialog to appear and click the button
-        # Use more specific selector to avoid clicking "Restore" button
+
+        # In CI, if protocol association is already configured, Chrome/Brave may auto-handle
+        # the external protocol WITHOUT showing any permission dialog. In that case there
+        # may be 0 buttons on /checking, and waiting for a dialog will just time out.
+        if "auth.immutable.com/checking" in current_url_lower and len(buttons) == 0:
+            print("No deep link permission dialog present on /checking (0 buttons).")
+            print("Assuming protocol is already permitted; waiting for Unity to process callback via Player.log...")
+            wait_for_authentication_success_in_unity_logs(timeout_seconds=75)
+            return
+
+        # Otherwise, try to click the deep link dialog if it appears.
+        # Use more specific selector to avoid clicking "Restore" button.
         product_name = os.getenv("UNITY_APP_NAME", get_product_name())
-        deep_link_button = wait.until(EC.element_to_be_clickable((By.XPATH, f"//button[text()='Open {product_name}.cmd']")))
+        dialog_wait = WebDriverWait(driver, 8)
+        deep_link_button = dialog_wait.until(
+            EC.element_to_be_clickable((By.XPATH, f"//button[text()='Open {product_name}.cmd']"))
+        )
         deep_link_button.click()
         print("Clicked deep link permission dialog - Unity should receive redirect")
     except Exception as e:
         print(f"Deep link dialog not found or failed to click: {e}")
-        print("This may cause the test to timeout waiting for scene change")
+        print("Assuming dialog was suppressed/auto-handled; waiting for Unity to process callback via Player.log...")
+        wait_for_authentication_success_in_unity_logs(timeout_seconds=75)
 
     # Keep browser alive for Unity deep link redirect
     # driver.quit()