Skip to content

Commit 9132bc0

Browse files
refactor(audience-sample): use SampleAppUi.Css references for inline CSS classes
AudienceSample.UI.cs RefreshStatusBar set status-cell classes via inline strings ("state-warn", "state-ok", and "dim" five times) even though SampleAppUi.Css.StateWarn / .StateOk / .Dim already exist for exactly this purpose. Migrates seven call sites to the constants. CSS-side renames now need to touch one place (Css.Dim) instead of grep-and-replace across the SetStatusCell call sites. Per the user's "everything random goes in a constant" stance. Follow-up to SDK-272 (centralisation of duplicated literals).
1 parent 3932b02 commit 9132bc0

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

examples/audience/Assets/SampleApp/Scripts/AudienceSample.UI.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -533,17 +533,17 @@ private void RefreshStatusBar()
533533
string? derivedFromKey = keyEmpty ? null : (isTest ? Constants.SandboxBaseUrl : Constants.ProductionBaseUrl);
534534
string? endpoint = hasOverride ? overrideUrl : derivedFromKey;
535535
bool warnState = hasOverride || (!keyEmpty && !isTest);
536-
SetStatusCell(_statusEndpoint, endpoint, warnState ? "state-warn" : "state-ok");
536+
SetStatusCell(_statusEndpoint, endpoint, warnState ? SampleAppUi.Css.StateWarn : SampleAppUi.Css.StateOk);
537537
_prodWarning.EnableInClassList(SampleAppUi.HiddenClass, hasOverride || keyEmpty || isTest);
538538

539539
var consent = _initialised ? ImmutableAudience.CurrentConsent : ConsentOrder[Mathf.Clamp(_initialConsent?.index ?? 0, 0, ConsentOrder.Length - 1)];
540540
int cIdx = Array.IndexOf(ConsentOrder, consent);
541-
SetStatusCell(_statusConsent, consent.ToLowercaseString(), cIdx >= 0 ? ConsentStateClass[cIdx] : "dim");
541+
SetStatusCell(_statusConsent, consent.ToLowercaseString(), cIdx >= 0 ? ConsentStateClass[cIdx] : SampleAppUi.Css.Dim);
542542

543-
SetStatusCell(_statusAnon, _initialised ? ImmutableAudience.AnonymousId : null, "dim");
544-
SetStatusCell(_statusUser, _initialised ? ImmutableAudience.UserId : null, "dim");
545-
SetStatusCell(_statusSession, _initialised ? ImmutableAudience.SessionId : null, "dim");
546-
SetStatusCell(_statusQueue, _initialised ? ImmutableAudience.QueueSize.ToString(CultureInfo.InvariantCulture) : null, "dim");
543+
SetStatusCell(_statusAnon, _initialised ? ImmutableAudience.AnonymousId : null, SampleAppUi.Css.Dim);
544+
SetStatusCell(_statusUser, _initialised ? ImmutableAudience.UserId : null, SampleAppUi.Css.Dim);
545+
SetStatusCell(_statusSession, _initialised ? ImmutableAudience.SessionId : null, SampleAppUi.Css.Dim);
546+
SetStatusCell(_statusQueue, _initialised ? ImmutableAudience.QueueSize.ToString(CultureInfo.InvariantCulture) : null, SampleAppUi.Css.Dim);
547547
}
548548

549549
private void RefreshConsentPills()

0 commit comments

Comments
 (0)