fix(windows): apply protocol permissions to brave profile and dump Player.log

Author: rodrigo-fournier-immutable

sample/Tests/test/test_windows.py

@@ -12,7 +12,7 @@
 from alttester import *
 
 from test import TestConfig, UnityTest
-from test_windows_helpers import login, open_sample_app, launch_browser, bring_sample_app_to_foreground, stop_browser, stop_sample_app, logout_with_controlled_browser
+from test_windows_helpers import login, open_sample_app, launch_browser, bring_sample_app_to_foreground, stop_browser, stop_sample_app, logout_with_controlled_browser, get_product_name
 
 class WindowsTest(UnityTest):
 
@@ -127,6 +127,30 @@ def _perform_login(self):
             print("[SUCCESS] Login successful")
 
         except Exception as err:
+            # Dump Player.log tail to help diagnose why the deep-link callback
+            # wasn't processed (or why Unity failed after receiving it).
+            try:
+                import os
+                product_name = os.getenv("UNITY_APP_NAME", get_product_name())
+                log_path = os.path.join(
+                    "C:\\Users\\WindowsBuildsdkServi\\AppData\\LocalLow\\Immutable",
+                    product_name,
+                    "Player.log",
+                )
+                print(f"Attempting to dump Unity Player.log tail: {log_path}")
+                if os.path.exists(log_path):
+                    with open(log_path, "r", encoding="utf-8", errors="ignore") as f:
+                        lines = f.read().splitlines()
+                    tail = lines[-250:] if len(lines) > 250 else lines
+                    print("----- Player.log (tail) -----")
+                    for line in tail:
+                        print(line)
+                    print("----- end Player.log (tail) -----")
+                else:
+                    print("Player.log not found.")
+            except Exception as e:
+                print(f"Failed to dump Player.log: {e}")
+
             stop_browser()
             raise SystemExit(f"Login failed: {err}")
 

sample/Tests/test/test_windows_helpers.py

@@ -660,10 +660,27 @@ def login():
 
         # The "open external protocol" prompt is typically browser UI (not DOM),
         # so 0 buttons on /checking is expected. Try:
+        # - wait for /checking to transition (some runs redirect after a few seconds)
         # - wait briefly for Unity success (maybe protocol already fired)
         # - click the browser-level prompt via UIAutomation
         # - wait again for Unity success
         if "auth.immutable.com/checking" in current_url_lower:
+            # Monitor for URL transitions for ~30 seconds.
+            for _ in range(15):
+                time.sleep(2)
+                try:
+                    current = driver.current_url or ""
+                    print(f"/checking monitor - current URL: {current}")
+                    lower = current.lower()
+                    if "newtab" in lower or "about:blank" in lower:
+                        print("Detected newtab/about:blank; assuming external protocol launch was attempted.")
+                        wait_for_authentication_success_in_unity_logs(timeout_seconds=75)
+                        return
+                    if "auth.immutable.com/checking" not in lower:
+                        break
+                except Exception:
+                    pass
+
             if wait_for_authentication_success_in_unity_logs(timeout_seconds=10):
                 return
 
@@ -810,14 +827,11 @@ def bring_sample_app_to_foreground():
     subprocess.run(command, check=True)
     time.sleep(10)
 
-def setup_browser_permissions():
-    """Set up browser permissions to allow auth.immutable.com to open external applications"""
+def setup_browser_permissions(user_data_dir: str):
+    """Set up browser profile permissions to allow auth.immutable.com to open external applications."""
     print("Setting up browser permissions for auth.immutable.com...")
-    
-    # Create a browser preferences file to pre-allow the domain
-    user_data_dir = "C:\\temp\\brave_debug"
-    if not os.path.exists(user_data_dir):
-        os.makedirs(user_data_dir, exist_ok=True)
+    print(f"Using browser profile dir: {user_data_dir}")
+    os.makedirs(user_data_dir, exist_ok=True)
 
     # Create preferences file that allows auth.immutable.com to open external apps
     preferences = {
@@ -864,16 +878,27 @@ def setup_autolaunch_protocol_policy():
     # This must be REG_SZ containing JSON.
     # Protocol must be lowercase and WITHOUT ':' (e.g. "immutablerunner", not "immutablerunner:").
     policy_json = (
-        '[{"protocol":"immutablerunner","allowed_origins":["https://auth.immutable.com"]}]'
+        '[{"protocol":"immutablerunner","allowed_origins":["https://auth.immutable.com","https://auth.immutable.com:443"]}]'
     )
 
     ps_script = f'''
-    $key = "HKCU:\\Software\\Policies\\BraveSoftware\\Brave"
-    if (!(Test-Path $key)) {{
-      New-Item -Path $key -Force | Out-Null
+    $json = '{policy_json}'
+    $paths = @(
+      "HKCU:\\Software\\Policies\\BraveSoftware\\Brave",
+      "HKLM:\\Software\\Policies\\BraveSoftware\\Brave"
+    )
+
+    foreach ($key in $paths) {{
+      try {{
+        if (!(Test-Path $key)) {{
+          New-Item -Path $key -Force | Out-Null
+        }}
+        New-ItemProperty -Path $key -Name "AutoLaunchProtocolsFromOrigins" -PropertyType String -Value $json -Force | Out-Null
+        Write-Host "Brave policy AutoLaunchProtocolsFromOrigins set at $key."
+      }} catch {{
+        Write-Host "Failed to set policy at $key: $($_.Exception.Message)"
+      }}
     }}
-    New-ItemProperty -Path $key -Name "AutoLaunchProtocolsFromOrigins" -PropertyType String -Value '{policy_json}' -Force | Out-Null
-    Write-Host "Brave policy AutoLaunchProtocolsFromOrigins set."
     '''
 
     try:
@@ -956,11 +981,6 @@ def setup_protocol_association():
 def launch_browser():
     print("Starting Brave...")
 
-    # Set up browser permissions and protocol association first
-    setup_browser_permissions()
-    setup_protocol_association()
-    setup_autolaunch_protocol_policy()
-    
     browser_paths = [
         r"C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe"
     ]
@@ -978,6 +998,11 @@ def launch_browser():
     # Create a temporary directory for browser data to ensure clean state
     import tempfile
     temp_user_data = tempfile.mkdtemp(prefix='brave_test_')
+
+    # IMPORTANT: apply permissions to the SAME profile we launch with.
+    setup_browser_permissions(user_data_dir=temp_user_data)
+    setup_protocol_association()
+    setup_autolaunch_protocol_policy()
 
     # Launch Brave with CI-friendly flags to handle protocol dialogs automatically
     browser_args = [