Skip to content

Commit f0fd39c

Browse files
test(audience-sdk): extend TestFixtures with Steam / Passport / generic user ID fixtures
ImmutableAudienceTests had four inline ID fixtures around the identity / alias write tests: - "76561198012345": real-shape Steam community 64-bit ID, used as the Identify input AND as the queue-content assertion subject - "user1": minimal generic userId for the discarded-identify test - "steam123": generic Steam ID for the alias-write test, used as both Alias input and queue-content assertion subject - "user_456": generic Passport ID for the alias-write test Adds SteamId64, GenericUserSingleId, SteamId, PassportId to TestFixtures and migrates the six call sites. The SteamId64 / SteamId input-assertion pairs were the worst offenders since a typo on one side would silently pass on the other. Per the user's "everything random goes in a constant" stance. Follow-up to SDK-272 (centralisation of duplicated literals).
1 parent 2ff6e44 commit f0fd39c

2 files changed

Lines changed: 15 additions & 5 deletions

File tree

src/Packages/Audience/Tests/Runtime/ImmutableAudienceTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -620,22 +620,22 @@ public void Identify_FullConsent_WritesIdentifyEvent()
620620
{
621621
ImmutableAudience.Init(MakeConfig(ConsentLevel.Full));
622622

623-
ImmutableAudience.Identify("76561198012345", IdentityType.Steam);
623+
ImmutableAudience.Identify(TestFixtures.SteamId64, IdentityType.Steam);
624624
ImmutableAudience.Shutdown();
625625

626626
var queueDir = AudiencePaths.QueueDir(_testDir);
627627
var contents = Directory.GetFiles(queueDir, AudiencePaths.QueueGlob)
628628
.Select(File.ReadAllText).ToList();
629629
Assert.IsTrue(contents.Any(c =>
630-
c.Contains($"\"{MessageTypes.Identify}\"") && c.Contains("\"76561198012345\"")));
630+
c.Contains($"\"{MessageTypes.Identify}\"") && c.Contains($"\"{TestFixtures.SteamId64}\"")));
631631
}
632632

633633
[Test]
634634
public void Identify_AnonymousConsent_IsIgnored()
635635
{
636636
ImmutableAudience.Init(MakeConfig(ConsentLevel.Anonymous));
637637

638-
ImmutableAudience.Identify("user1", IdentityType.Steam);
638+
ImmutableAudience.Identify(TestFixtures.GenericUserSingleId, IdentityType.Steam);
639639
ImmutableAudience.Shutdown();
640640

641641
var queueDir = AudiencePaths.QueueDir(_testDir);
@@ -650,14 +650,14 @@ public void Alias_FullConsent_WritesAliasEvent()
650650
{
651651
ImmutableAudience.Init(MakeConfig(ConsentLevel.Full));
652652

653-
ImmutableAudience.Alias("steam123", IdentityType.Steam, "user_456", IdentityType.Passport);
653+
ImmutableAudience.Alias(TestFixtures.SteamId, IdentityType.Steam, TestFixtures.PassportId, IdentityType.Passport);
654654
ImmutableAudience.Shutdown();
655655

656656
var queueDir = AudiencePaths.QueueDir(_testDir);
657657
var contents = Directory.GetFiles(queueDir, AudiencePaths.QueueGlob)
658658
.Select(File.ReadAllText).ToList();
659659
Assert.IsTrue(contents.Any(c =>
660-
c.Contains($"\"{MessageTypes.Alias}\"") && c.Contains("\"steam123\"")));
660+
c.Contains($"\"{MessageTypes.Alias}\"") && c.Contains($"\"{TestFixtures.SteamId}\"")));
661661
}
662662

663663
// -----------------------------------------------------------------

src/Packages/Audience/Tests/Runtime/TestFixtures.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,5 +92,15 @@ internal static class TestFixtures
9292
internal const string GenericAliasFromId = "fromId";
9393
internal const string GenericAliasToId = "toId";
9494
internal const string GenericAliasFromShort = "from";
95+
96+
// Real-shape 64-bit Steam community ID. Asserts the input is carried through faithfully.
97+
internal const string SteamId64 = "76561198012345";
98+
99+
// Generic Steam / Passport ID fixtures used by alias and consent tests.
100+
internal const string SteamId = "steam123";
101+
internal const string PassportId = "user_456";
102+
103+
// Generic single-user fixture for tests that just need any userId.
104+
internal const string GenericUserSingleId = "user1";
95105
}
96106
}

0 commit comments

Comments
 (0)