Merge pull request #735 from immutable/feat/sdk-296-android-device-collector

feat(audience-sdk): extend DeviceCollector with Android-specific signals (SDK-296)

Author: nattb8

src/Packages/Audience/Runtime/Unity/DeviceCollector.cs

@@ -66,6 +66,9 @@ internal static Dictionary<string, object> CollectGameLaunchProperties()
             var dpi = (int)Screen.dpi;
             if (dpi > 0) props["screenDpi"] = dpi;
 
+            if (Application.platform == RuntimePlatform.Android)
+                props["androidId"] = Truncate(SystemInfo.deviceUniqueIdentifier, 256);
+
             return props;
         }
 

src/Packages/Audience/Tests/Audience.Tests.csproj

@@ -22,5 +22,9 @@
   -->
   <ItemGroup>
     <Compile Remove="Editor/**/*.cs" />
+    <!-- DeviceCollectorTests references Immutable.Audience.Unity which wraps
+         UnityEngine APIs unavailable in the headless dotnet build. These tests
+         run inside the Unity Test Framework via the asmdef instead. -->
+    <Compile Remove="Runtime/Unity/**/*.cs" />
   </ItemGroup>
 </Project>

src/Packages/Audience/Tests/Runtime/Unity/DeviceCollectorTests.cs

@@ -0,0 +1,93 @@
+#nullable enable
+
+using System.Collections.Generic;
+using NUnit.Framework;
+using Immutable.Audience.Unity;
+
+namespace Immutable.Audience.Tests
+{
+    [TestFixture]
+    internal class DeviceCollectorTests
+    {
+        // -----------------------------------------------------------------
+        // CollectContext
+        // -----------------------------------------------------------------
+
+        [Test]
+        public void CollectContext_AlwaysContainsUserAgent()
+        {
+            var ctx = DeviceCollector.CollectContext();
+            Assert.IsTrue(ctx.ContainsKey("userAgent"), "userAgent must always be present");
+            Assert.IsNotNull(ctx["userAgent"]);
+        }
+
+        [Test]
+        public void CollectContext_UserAgent_DoesNotExceed256Chars()
+        {
+            var ctx = DeviceCollector.CollectContext();
+            Assert.LessOrEqual(ctx["userAgent"].ToString()!.Length, 256);
+        }
+
+        [Test]
+        public void CollectContext_KnownStringKeys_AreWithin256Chars()
+        {
+            var ctx = DeviceCollector.CollectContext();
+            foreach (var key in new[] { "userAgent", "timezone", "locale", "screen" })
+            {
+                if (!ctx.TryGetValue(key, out var val)) continue;
+                Assert.LessOrEqual(val.ToString()!.Length, 256,
+                    $"context[{key}] exceeds 256 chars");
+            }
+        }
+
+        // -----------------------------------------------------------------
+        // CollectGameLaunchProperties
+        // -----------------------------------------------------------------
+
+        [Test]
+        public void CollectGameLaunchProperties_AlwaysContainsCrossPlatformFields()
+        {
+            var props = DeviceCollector.CollectGameLaunchProperties();
+            foreach (var key in new[] {
+                "platform", "version", "buildGuid", "unityVersion",
+                "osFamily", "deviceModel", "gpu", "gpuVendor",
+                "cpu", "cpuCores", "ramMb" })
+            {
+                Assert.IsTrue(props.ContainsKey(key), $"expected key '{key}' to be present");
+            }
+        }
+
+        [Test]
+        public void CollectGameLaunchProperties_StringFields_DoNotExceed256Chars()
+        {
+            var props = DeviceCollector.CollectGameLaunchProperties();
+            foreach (var key in new[] {
+                "platform", "version", "buildGuid", "unityVersion",
+                "osFamily", "deviceModel", "gpu", "gpuVendor", "cpu" })
+            {
+                if (!props.TryGetValue(key, out var val) || val is not string s) continue;
+                Assert.LessOrEqual(s.Length, 256, $"props[{key}] exceeds 256 chars");
+            }
+        }
+
+        [Test]
+        public void CollectGameLaunchProperties_NonAndroid_DoesNotContainAndroidId()
+        {
+            // Regression guard: androidId must only appear on Android. Running
+            // tests on Editor/Standalone should never populate this field.
+            var props = DeviceCollector.CollectGameLaunchProperties();
+            Assert.IsFalse(props.ContainsKey("androidId"),
+                "androidId must not be present on non-Android platforms");
+        }
+
+        [Test]
+        public void CollectGameLaunchProperties_ScreenDpi_AbsentWhenZero()
+        {
+            // Screen.dpi returns 0 on some Linux WMs; the implementation
+            // must omit the key rather than forwarding a zero value.
+            var props = DeviceCollector.CollectGameLaunchProperties();
+            if (props.TryGetValue("screenDpi", out var dpi))
+                Assert.Greater((int)dpi, 0, "screenDpi must not be 0 when present");
+        }
+    }
+}

src/Packages/Audience/Tests/Runtime/com.immutable.audience.tests.asmdef

@@ -3,6 +3,7 @@
     "rootNamespace": "Immutable.Audience.Tests",
     "references": [
         "Immutable.Audience.Runtime",
+        "Immutable.Audience.Unity",
         "UnityEngine.TestRunner",
         "UnityEditor.TestRunner"
     ],