ci(audience-sdk): stop running Unity tests on docs-only PRs (SDK-268)#720
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f5fbb6b. Configure here.
…SDK-268) Replaces the blanket src/Packages/Audience/** and examples/audience/** match with explicit allow-lists, so doc-only PRs (README.md, gitignore, etc.) no longer schedule the 12-cell PlayMode matrix or the .NET unit tests. Triggers now require a change to one of: - src/Packages/Audience/Runtime/** - src/Packages/Audience/Tests/** - src/Packages/Audience/package.json - src/Packages/Audience/Directory.Build.props - src/Packages/Audience/link.xml (IL2CPP stripping config) - examples/audience/Assets/** (sample-app workflow only) - examples/audience/Packages/** (sample-app workflow only) - examples/audience/ProjectSettings/** (sample-app workflow only) - the workflow file itself paths-ignore is not viable here: it only suppresses a workflow when every changed file matches the ignore list, so a mixed PR (markdown + package.json) would still trigger. Allow-listing is the only filter shape that handles this correctly. package.json stays in the trigger because real version, dependency, and unity-minimum changes live there and the matrix is exactly what should catch a typo. The cost of running on a metadata-only edit is the price of treating package.json as load-bearing. link.xml is included because it controls which managed types survive IL2CPP stripping in Player builds. A change there can produce runtime-only failures that only the PlayMode matrix can catch. Linear: SDK-268 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
f5fbb6b to
e621a7f
Compare
bkbooth
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
README.mdundersrc/Packages/Audience/) currently trigger the full Audience CI surface —test-audience-sample-app.ymlruns all 12 self-hosted Unity PlayMode cells, andtest-audience-sdk.ymlruns the .NET unit-test job.paths:filter to the entire package and example directories (src/Packages/Audience/**,examples/audience/**), with no carve-out for documentation or repo metadata.test-audience-sdk.ymlnow triggers on:src/Packages/Audience/Runtime/**src/Packages/Audience/Tests/**src/Packages/Audience/package.jsonsrc/Packages/Audience/Directory.Build.propssrc/Packages/Audience/link.xml.github/workflows/test-audience-sdk.ymltest-audience-sample-app.ymltriggers on the same paths, plus:examples/audience/Assets/**examples/audience/Packages/**examples/audience/ProjectSettings/**.github/workflows/test-audience-sample-app.ymlpathsandpaths-ignoreare mutually exclusive in GitHub Actions, andpaths-ignoreonly suppresses a workflow when every changed file matches the ignore list — so a mixed change (markdown +package.json) would still trigger. An explicit allow-list is the only filter shape that handles mixed PRs correctly.package.json,Directory.Build.props, andlink.xmlstay in the trigger because version, dependency, build-config, and IL2CPP-stripping changes can each produce regressions the matrix exists to catch.Linear: SDK-268