Fix CI breakages surfaced by PR #115 #116
Merged
Merged
Conversation
lfportal
approved these changes
May 22, 2026
mw-w
approved these changes
May 22, 2026
ermyas
added a commit
that referenced
this pull request
May 22, 2026
* Harden CI workflows and actions
- SHA-pin all external actions (checkout v6.0.2, setup-node v6.4.0, foundry-toolchain v1.8.0, slither-action v0.4.2)
- Remove custom PAT (ZKEVM_BRIDGE_CONTRACTS_GITHUB_TOKEN), use native github.token scoped to the coverage publish step
- Add permissions: {} at workflow level with least-privilege job-level permissions
- Add persist-credentials: false to all checkout steps
- Collapse four on-push workflows (e2e, lint, static-analysis, test) into a single ci.yml with parallel jobs
- Extract setup-node and setup-foundry composite actions to centralize SHA pins
- Remove borales/actions-yarn (yarn is pre-installed on runners) and node-cache action (replaced by setup-node built-in caching)
- Harden yarn install with --frozen-lockfile --ignore-scripts --non-interactive
- Rewrite coverage action in TypeScript (node16 → node20), using context.repo instead of hardcoded owner/repo, with ESLint + Rollup build toolchain on pnpm
- Add Dependabot configuration for github-actions and npm ecosystems
- Resolves all zizmor findings
* Fix CI breakages surfaced by PR #115 (#116)
* Fix formatting
* Fix variable name conflict
* Fix missing checkout for Slither CI job
* Fix E2E by using ts-node CJS register in mocharc
* Fix coverage CI by excluding invariant suite requiring localhost RPC
---------
Co-authored-by: Ermyas Abebe <ermyast@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes CI breaking issues surfaced in PR #115