Skip to content

Commit b95cc32

Browse files
committed
WeightDecay before ClipNorm
1 parent 9830742 commit b95cc32

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

examples/usage.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ if !isfile(icnf_mach_fn)
8484
icnf,
8585
optimizers = (
8686
OptimiserChain(
87-
ClipNorm(1.0f0, 2.0f0; throw = true),
8887
WeightDecay(; lambda = 1.0f-2),
88+
ClipNorm(1.0f0, 2.0f0; throw = true),
8989
Adam(; eta = 1.0f-3, beta = (9.0f-1, 9.99f-1), epsilon = eps(Float32)),
9090
),
9191
),

src/exts/mlj_ext/core_cond_icnf.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ function CondICNFModel(;
1212
loss::Function = loss,
1313
optimizers::Tuple = (
1414
Optimisers.OptimiserChain(
15+
Optimisers.WeightDecay(; lambda = convert(eltype(icnf), 1.0e-2)),
1516
Optimisers.ClipNorm(
1617
one(eltype(icnf)),
1718
convert(eltype(icnf), 2.0e0);
1819
throw = true,
1920
),
20-
Optimisers.WeightDecay(; lambda = convert(eltype(icnf), 1.0e-2)),
2121
Optimisers.Adam(;
2222
eta = convert(eltype(icnf), 1.0e-3),
2323
beta = (convert(eltype(icnf), 9.0e-1), convert(eltype(icnf), 9.99e-1)),

src/exts/mlj_ext/core_icnf.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ function ICNFModel(;
1212
loss::Function = loss,
1313
optimizers::Tuple = (
1414
Optimisers.OptimiserChain(
15+
Optimisers.WeightDecay(; lambda = convert(eltype(icnf), 1.0e-2)),
1516
Optimisers.ClipNorm(
1617
one(eltype(icnf)),
1718
convert(eltype(icnf), 2.0e0);
1819
throw = true,
1920
),
20-
Optimisers.WeightDecay(; lambda = convert(eltype(icnf), 1.0e-2)),
2121
Optimisers.Adam(;
2222
eta = convert(eltype(icnf), 1.0e-3),
2323
beta = (convert(eltype(icnf), 9.0e-1), convert(eltype(icnf), 9.99e-1)),

0 commit comments

Comments
 (0)