Skip to content

fix: ui_playground#59

Open
vanlooverenkoen wants to merge 3 commits into
mainfrom
feat/ui-playground
Open

fix: ui_playground#59
vanlooverenkoen wants to merge 3 commits into
mainfrom
feat/ui-playground

Conversation

@vanlooverenkoen
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 27, 2026 07:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a UI Playground entry point in the example app (with generated component registrations) and adds a small CLI + shell scripts to automate formatting/analyzing/build_runner and scaffold new components/building blocks.

Changes:

  • Add ui_playground dependencies and a new UiPlaygroundScreen, linked from the home screen.
  • Commit a generated *.ui_playground.dart aggregator and exclude these files from analyzer warnings.
  • Add tools/ shell scripts plus a tools/cli Dart CLI to scaffold component/building-block code and example library entries.

Reviewed changes

Copilot reviewed 7 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/packages_get.sh Adds a helper script to fetch Flutter packages.
tools/format.sh Adds a helper script to run dart format.
tools/cli/pubspec.yaml Introduces a new Dart CLI package definition.
tools/cli/pubspec.lock Locks dependencies for the CLI package.
tools/cli/bin/widget_library.dart CLI entrypoint for scaffolding components/building blocks.
tools/cli/bin/src/utils.dart String case conversion helpers for the scaffolder.
tools/cli/bin/src/component_library.dart Scaffolds component + example component-library files.
tools/cli/bin/src/building_block_library.dart Scaffolds building-block + example building-block library files.
tools/build_runner_build.sh Adds a helper script to run build_runner in example/.
tools/analyze.sh Adds a helper script to run flutter analyze.
example/pubspec.yaml Adds UI Playground deps and build_runner; introduces dependency overrides.
example/pubspec.lock Updates lockfile to include UI Playground + build_runner dependency graph.
example/lib/src/ui_playground/impaktfull_ui_components.ui_playground.dart Adds generated UI Playground registry for components.
example/lib/src/ui_playground/impaktfull_ui_components.dart Adds UI Playground annotation/config driving codegen.
example/lib/src/screen/ui_playground/ui_playground_screen.dart Adds a screen hosting the UI Playground app/sections.
example/lib/src/screen/home/home_screen.dart Adds navigation entry to UI Playground from the home screen.
analysis_options.yaml Excludes *.ui_playground.dart files from analysis.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread example/pubspec.yaml
Comment on lines +26 to 35
dependency_overrides:
ui_playground:
path: /Users/vanlooverenkoen/work/open_source/impaktfull/flutter_ui_playground/ui_playground
ui_playground_annotations:
path: /Users/vanlooverenkoen/work/open_source/impaktfull/flutter_ui_playground/ui_playground_annotations
ui_playground_generator:
path: /Users/vanlooverenkoen/work/open_source/impaktfull/flutter_ui_playground/ui_playground_generator
impaktfull_ui:
path: ..

Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependency_overrides contains absolute local paths under /Users/..., which will break for other developers and CI (pub get will fail and the lockfile will pin to non-existent paths). Replace these with hosted/git/relative path overrides appropriate for the repo, or remove overrides before merging and regenerate pubspec.lock.

Suggested change
dependency_overrides:
ui_playground:
path: /Users/vanlooverenkoen/work/open_source/impaktfull/flutter_ui_playground/ui_playground
ui_playground_annotations:
path: /Users/vanlooverenkoen/work/open_source/impaktfull/flutter_ui_playground/ui_playground_annotations
ui_playground_generator:
path: /Users/vanlooverenkoen/work/open_source/impaktfull/flutter_ui_playground/ui_playground_generator
impaktfull_ui:
path: ..

Copilot uses AI. Check for mistakes.
Comment on lines +3 to +4
cd example
flutter pub run build_runner build --delete-conflicting-outputs No newline at end of file
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script assumes it’s invoked from the repo root (cd example) and uses flutter directly while other tooling scripts use fvm. To make it robust, cd relative to the script location (or repo root) and consistently use fvm flutter pub run build_runner ...; also consider set -euo pipefail so failures don’t go unnoticed.

Suggested change
cd example
flutter pub run build_runner build --delete-conflicting-outputs
set -euo pipefail
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
cd "${SCRIPT_DIR}/../example"
fvm flutter pub run build_runner build --delete-conflicting-outputs

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants