Merge branch 'master' into flowtype-wrong-import

Author: benmosher

.travis.yml

@@ -1,30 +1,50 @@
 language: node_js
 node_js:
-  - 4
-  - 6
-  - 8
+  - '8'
+  - '6'
+  - '4'
 
-os:
-  - linux
-  - osx
+os: linux
 
 env:
-  - ESLINT_VERSION=2
-  - ESLINT_VERSION=3
   - ESLINT_VERSION=4
+  - ESLINT_VERSION=3
+  - ESLINT_VERSION=2
+
+# osx backlog is often deep, so to be polite we can just hit these highlights
+matrix:
+  include:
+  - env: PACKAGE=resolvers/node
+    node_js: 8
+  - env: PACKAGE=resolvers/node
+    node_js: 6
+  - env: PACKAGE=resolvers/node
+    node_js: 4
+  - env: PACKAGE=resolvers/webpack
+    node_js: 8
+  - env: PACKAGE=resolvers/webpack
+    node_js: 6
+  - env: PACKAGE=resolvers/webpack
+    node_js: 4
+  - os: osx
+    env: ESLINT_VERSION=4
+    node_js: 8
+  - os: osx
+    env: ESLINT_VERSION=3
+    node_js: 6
+  - os: osx
+    env: ESLINT_VERSION=2
+    node_js: 4
 
+before_install:
+  - 'nvm install-latest-npm'
+  - 'if [ -n "${PACKAGE-}" ]; then cd "${PACKAGE}"; fi'
 install:
-  - if [ ${TRAVIS_NODE_VERSION} == "4" ]; then
-      npm install -g npm@3;
-    fi
   - npm install
-  - npm install eslint@$ESLINT_VERSION --ignore-scripts || true
-  # install all resolver deps
-  - "for resolver in ./resolvers/*; do cd $resolver && npm install && cd ../..; done"
+  - npm install --no-save eslint@$ESLINT_VERSION --ignore-scripts || true
 
 script:
-  - "npm test"
-  - "for resolver in ./resolvers/*; do cd $resolver && npm test && cd ../..; done"
+  - 'npm test'
 
 after_success:
   - npm run coveralls

CHANGELOG.md

@@ -5,11 +5,43 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
 
 ## [Unreleased]
 ### Added
+- Ignore type imports for [`named`] rule ([#931], thanks [@mattijsbliek])
+- Add documentation for [`no-useless-path-segments`] rule ([#1068], thanks [@manovotny])
+
+
+# [2.11.0] - 2018-04-09
+### Added
+- Fixer for [`first`] ([#1046], thanks [@fengkfengk])
+- `allow-require` option for [`no-commonjs`] rule ([#880], thanks [@futpib])
+
+### Fixed
+- memory/CPU regression where ASTs were held in memory ([#1058], thanks [@klimashkin]/[@lukeapage])
+
+## [2.10.0] - 2018-03-29
+### Added
+- Autofixer for [`order`] rule ([#908], thanks [@tihonove])
+- Add [`no-cycle`] rule: reports import cycles.
+
+## [2.9.0] - 2018-02-21
+### Added
+- Add [`group-exports`] rule: style-guide rule to report use of multiple named exports ([#721], thanks [@robertrossmann])
+- Add [`no-self-import`] rule: forbids a module from importing itself. ([#727], [#449], [#447], thanks [@giodamelio]).
+- Add [`no-default-export`] rule ([#889], thanks [@isiahmeadows])
+- Add [`no-useless-path-segments`] rule ([#912], thanks [@graingert] and [@danny-andrews])
+- ... and more! check the commits for v[2.9.0]
+
+## [2.8.0] - 2017-10-18
+### Added
 - [`exports-last`] rule ([#620] + [#632], thanks [@k15a])
 
 ### Changed
 - Case-sensitivity checking ignores working directory and ancestors. ([#720] + [#858], thanks [@laysent])
 
+### Fixed
+- support scoped modules containing hyphens ([#744], thanks [@rosswarren])
+- core-modules now resolves files inside declared modules ([#886] / [#891], thanks [@mplewis])
+- TypeError for missing AST fields from TypeScript ([#842] / [#944], thanks [@alexgorbatchev])
+
 ## [2.7.0] - 2017-07-06
 ### Changed
 - [`no-absolute-path`] picks up speed boost, optional AMD support ([#843], thanks [@jseminck])
@@ -423,14 +455,29 @@ for info on changes for earlier releases.
 [`unambiguous`]: ./docs/rules/unambiguous.md
 [`no-anonymous-default-export`]: ./docs/rules/no-anonymous-default-export.md
 [`exports-last`]: ./docs/rules/exports-last.md
+[`group-exports`]: ./docs/rules/group-exports.md
+[`no-self-import`]: ./docs/rules/no-self-import.md
+[`no-default-export`]: ./docs/rules/no-default-export.md
+[`no-useless-path-segments`]: ./docs/rules/no-useless-path-segments.md
+[`no-cycle`]: ./docs/rules/no-cycle.md
 
 [`memo-parser`]: ./memo-parser/README.md
 
+[#1068]: https://github.com/benmosher/eslint-plugin-import/pull/1068
+[#1046]: https://github.com/benmosher/eslint-plugin-import/pull/1046
+[#944]: https://github.com/benmosher/eslint-plugin-import/pull/944
+[#908]: https://github.com/benmosher/eslint-plugin-import/pull/908
+[#891]: https://github.com/benmosher/eslint-plugin-import/pull/891
+[#889]: https://github.com/benmosher/eslint-plugin-import/pull/889
+[#880]: https://github.com/benmosher/eslint-plugin-import/pull/880
 [#858]: https://github.com/benmosher/eslint-plugin-import/pull/858
 [#843]: https://github.com/benmosher/eslint-plugin-import/pull/843
 [#871]: https://github.com/benmosher/eslint-plugin-import/pull/871
+[#744]: https://github.com/benmosher/eslint-plugin-import/pull/744
 [#742]: https://github.com/benmosher/eslint-plugin-import/pull/742
 [#737]: https://github.com/benmosher/eslint-plugin-import/pull/737
+[#727]: https://github.com/benmosher/eslint-plugin-import/pull/727
+[#721]: https://github.com/benmosher/eslint-plugin-import/pull/721
 [#712]: https://github.com/benmosher/eslint-plugin-import/pull/712
 [#696]: https://github.com/benmosher/eslint-plugin-import/pull/696
 [#685]: https://github.com/benmosher/eslint-plugin-import/pull/685
@@ -454,6 +501,7 @@ for info on changes for earlier releases.
 [#489]: https://github.com/benmosher/eslint-plugin-import/pull/489
 [#485]: https://github.com/benmosher/eslint-plugin-import/pull/485
 [#461]: https://github.com/benmosher/eslint-plugin-import/pull/461
+[#449]: https://github.com/benmosher/eslint-plugin-import/pull/449
 [#444]: https://github.com/benmosher/eslint-plugin-import/pull/444
 [#428]: https://github.com/benmosher/eslint-plugin-import/pull/428
 [#395]: https://github.com/benmosher/eslint-plugin-import/pull/395
@@ -488,8 +536,13 @@ for info on changes for earlier releases.
 [#164]: https://github.com/benmosher/eslint-plugin-import/pull/164
 [#157]: https://github.com/benmosher/eslint-plugin-import/pull/157
 [#314]: https://github.com/benmosher/eslint-plugin-import/pull/314
+[#912]: https://github.com/benmosher/eslint-plugin-import/pull/912
 
+[#1058]: https://github.com/benmosher/eslint-plugin-import/issues/1058
+[#931]: https://github.com/benmosher/eslint-plugin-import/issues/931
+[#886]: https://github.com/benmosher/eslint-plugin-import/issues/886
 [#863]: https://github.com/benmosher/eslint-plugin-import/issues/863
+[#842]: https://github.com/benmosher/eslint-plugin-import/issues/842
 [#839]: https://github.com/benmosher/eslint-plugin-import/issues/839
 [#720]: https://github.com/benmosher/eslint-plugin-import/issues/720
 [#686]: https://github.com/benmosher/eslint-plugin-import/issues/686
@@ -517,6 +570,7 @@ for info on changes for earlier releases.
 [#456]: https://github.com/benmosher/eslint-plugin-import/issues/456
 [#453]: https://github.com/benmosher/eslint-plugin-import/issues/453
 [#452]: https://github.com/benmosher/eslint-plugin-import/issues/452
+[#447]: https://github.com/benmosher/eslint-plugin-import/issues/447
 [#441]: https://github.com/benmosher/eslint-plugin-import/issues/441
 [#423]: https://github.com/benmosher/eslint-plugin-import/issues/423
 [#416]: https://github.com/benmosher/eslint-plugin-import/issues/416
@@ -552,7 +606,11 @@ for info on changes for earlier releases.
 [#119]: https://github.com/benmosher/eslint-plugin-import/issues/119
 [#89]: https://github.com/benmosher/eslint-plugin-import/issues/89
 
-[Unreleased]: https://github.com/benmosher/eslint-plugin-import/compare/v2.7.0...HEAD
+[Unreleased]: https://github.com/benmosher/eslint-plugin-import/compare/v2.11.0...HEAD
+[2.11.0]: https://github.com/benmosher/eslint-plugin-import/compare/v2.10.0...v2.11.0
+[2.10.0]: https://github.com/benmosher/eslint-plugin-import/compare/v2.9.0...v2.10.0
+[2.9.0]: https://github.com/benmosher/eslint-plugin-import/compare/v2.8.0...v2.9.0
+[2.8.0]: https://github.com/benmosher/eslint-plugin-import/compare/v2.7.0...v2.8.0
 [2.7.0]: https://github.com/benmosher/eslint-plugin-import/compare/v2.6.1...v2.7.0
 [2.6.1]: https://github.com/benmosher/eslint-plugin-import/compare/v2.6.0...v2.6.1
 [2.6.0]: https://github.com/benmosher/eslint-plugin-import/compare/v2.5.0...v2.6.0
@@ -644,3 +702,17 @@ for info on changes for earlier releases.
 [@jseminck]: https://github.com/jseminck
 [@laysent]: https://github.com/laysent
 [@k15a]: https://github.com/k15a
+[@mplewis]: https://github.com/mplewis
+[@rosswarren]: https://github.com/rosswarren
+[@alexgorbatchev]: https://github.com/alexgorbatchev
+[@tihonove]: https://github.com/tihonove
+[@robertrossmann]: https://github.com/robertrossmann
+[@isiahmeadows]: https://github.com/isiahmeadows
+[@graingert]: https://github.com/graingert
+[@danny-andrews]: https://github.com/dany-andrews
+[@fengkfengk]: https://github.com/fengkfengk
+[@futpib]: https://github.com/futpib
+[@klimashkin]: https://github.com/klimashkin
+[@lukeapage]: https://github.com/lukeapage
+[@manovotny]: https://github.com/manovotny
+[@mattijsbliek]: https://github.com/mattijsbliek

README.md

@@ -12,7 +12,7 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 
 ## Rules
 
-**Static analysis:**
+### Static analysis
 
 * Ensure imports point to a file/module that can be resolved. ([`no-unresolved`])
 * Ensure named imports correspond to a named export in the remote file. ([`named`])
@@ -22,7 +22,10 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 * Forbid import of modules using absolute paths ([`no-absolute-path`])
 * Forbid `require()` calls with expressions ([`no-dynamic-require`])
 * Prevent importing the submodules of other modules ([`no-internal-modules`])
-* Forbid Webpack loader syntax in imports ([`no-webpack-loader-syntax`])
+* Forbid webpack loader syntax in imports ([`no-webpack-loader-syntax`])
+* Forbid a module from importing itself ([`no-self-import`])
+* Forbid a module from importing a module with a dependency path back to itself ([`no-cycle`])
+* Prevent unnecessary path segemnts in import and require statements ([`no-useless-path-segments`])
 
 [`no-unresolved`]: ./docs/rules/no-unresolved.md
 [`named`]: ./docs/rules/named.md
@@ -33,8 +36,11 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 [`no-dynamic-require`]: ./docs/rules/no-dynamic-require.md
 [`no-internal-modules`]: ./docs/rules/no-internal-modules.md
 [`no-webpack-loader-syntax`]: ./docs/rules/no-webpack-loader-syntax.md
+[`no-self-import`]: ./docs/rules/no-self-import.md
+[`no-cycle`]: ./docs/rules/no-cycle.md
+[`no-useless-path-segments`]: ./docs/rules/no-useless-path-segments.md
 
-**Helpful warnings:**
+### Helpful warnings
 
 
 * Report any invalid exports, i.e. re-export of the same name ([`export`])
@@ -51,7 +57,7 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 [`no-extraneous-dependencies`]: ./docs/rules/no-extraneous-dependencies.md
 [`no-mutable-exports`]: ./docs/rules/no-mutable-exports.md
 
-**Module systems:**
+### Module systems
 
 * Report potentially ambiguous parse goal (`script` vs. `module`) ([`unambiguous`])
 * Report CommonJS `require` calls and `module.exports` or `exports.*`. ([`no-commonjs`])
@@ -64,7 +70,7 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 [`no-nodejs-modules`]: ./docs/rules/no-nodejs-modules.md
 
 
-**Style guide:**
+### Style guide
 
 * Ensure all imports appear before other statements ([`first`])
 * Ensure all exports appear after other statements ([`exports-last`])
@@ -77,7 +83,10 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 * Limit the maximum number of dependencies a module can have ([`max-dependencies`])
 * Forbid unassigned imports ([`no-unassigned-import`])
 * Forbid named default exports ([`no-named-default`])
+* Forbid default exports ([`no-default-export`])
 * Forbid anonymous values as default exports ([`no-anonymous-default-export`])
+* Prefer named exports to be grouped together in a single export declaration ([`group-exports`])
+* Enforce a leading comment with the webpackChunkName for dynamic imports ([`dynamic-import-chunkname`])
 
 [`first`]: ./docs/rules/first.md
 [`exports-last`]: ./docs/rules/exports-last.md
@@ -91,6 +100,9 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 [`no-unassigned-import`]: ./docs/rules/no-unassigned-import.md
 [`no-named-default`]: ./docs/rules/no-named-default.md
 [`no-anonymous-default-export`]: ./docs/rules/no-anonymous-default-export.md
+[`group-exports`]: ./docs/rules/group-exports.md
+[`no-default-export`]: ./docs/rules/no-default-export.md
+[`dynamic-import-chunkname`]: ./docs/rules/dynamic-import-chunkname.md
 
 ## Installation
 
@@ -137,14 +149,14 @@ to find the file behind `module`.
 Up through v0.10ish, this plugin has directly used substack's [`resolve`] plugin,
 which implements Node's import behavior. This works pretty well in most cases.
 
-However, Webpack allows a number of things in import module source strings that
+However, webpack allows a number of things in import module source strings that
 Node does not, such as loaders (`import 'file!./whatever'`) and a number of
 aliasing schemes, such as [`externals`]: mapping a module id to a global name at
 runtime (allowing some modules to be included more traditionally via script tags).
 
 In the interest of supporting both of these, v0.11 introduces resolvers.
 
-Currently [Node] and [Webpack] resolution have been implemented, but the
+Currently [Node] and [webpack] resolution have been implemented, but the
 resolvers are just npm packages, so [third party packages are supported](https://github.com/benmosher/eslint-plugin-import/wiki/Resolvers) (and encouraged!).
 
 You can reference resolvers in several ways (in order of precedence):
@@ -210,7 +222,7 @@ If you are interesting in writing a resolver, see the [spec](./resolvers/README.
 [`externals`]: http://webpack.github.io/docs/library-and-externals.html
 
 [Node]: https://www.npmjs.com/package/eslint-import-resolver-node
-[Webpack]: https://www.npmjs.com/package/eslint-import-resolver-webpack
+[webpack]: https://www.npmjs.com/package/eslint-import-resolver-webpack
 
 # Settings
 
@@ -224,6 +236,19 @@ A list of file extensions that will be parsed as modules and inspected for
 This defaults to `['.js']`, unless you are using the `react` shared config,
 in which case it is specified as `['.js', '.jsx']`.
 
+```js
+"settings": {
+  "import/resolver": {
+    "node": {
+      "extensions": [
+        ".js",
+        ".jsx"
+      ]
+    }
+  }
+}
+```
+
 Note that this is different from (and likely a subset of) any `import/resolver`
 extensions settings, which may include `.json`, `.coffee`, etc. which will still
 factor into the `no-unresolved` rule.
@@ -282,7 +307,7 @@ An array of folders. Resolved modules only from those folders will be considered
 A map from parsers to file extension arrays. If a file extension is matched, the
 dependency parser will require and use the map key as the parser instead of the
 configured ESLint parser. This is useful if you're inter-op-ing with TypeScript
-directly using Webpack, for example:
+directly using webpack, for example:
 
 ```yaml
 # .eslintrc.yml

appveyor.yml

@@ -21,6 +21,10 @@ install:
       }
   - npm install
 
+  # fix symlinks
+  - cmd: git config core.symlinks true
+  - cmd: git reset --hard
+
   # todo: learn how to do this for all .\resolvers\* on Windows
   - cd .\resolvers\webpack && npm install && cd ..\..
   - cd .\resolvers\node && npm install && cd ..\..

config/recommended.js

@@ -3,6 +3,8 @@
  * @type {Object}
  */
 module.exports = {
+  plugins: ['import'],
+
   rules: {
     // analysis/correctness
     'import/no-unresolved': 'error',
@@ -14,8 +16,7 @@ module.exports = {
     // red flags (thus, warnings)
     'import/no-named-as-default': 'warn',
     'import/no-named-as-default-member': 'warn',
-    'import/no-duplicates': 'warn',
-    'import/unambiguous': 'warn',
+    'import/no-duplicates': 'warn'
   },
 
   // need all these for parsing dependencies (even if _your_ code doesn't need

docs/rules/default.md

@@ -1,4 +1,4 @@
-# default
+# import/default
 
 If a default import is requested, this rule will report if there is no default
 export in the imported module.