feat(IgnoreImports): allow ignored imports in no-extraneous-dependency#2557
Draft
kopax-polyconseil wants to merge 3 commits into
Draft
feat(IgnoreImports): allow ignored imports in no-extraneous-dependency#2557kopax-polyconseil wants to merge 3 commits into
kopax-polyconseil wants to merge 3 commits into
Conversation
Fix : import-js#2400 Idk how to use globs here, so it's no glob, and support `./` for rootDir
ljharb
requested changes
Jan 11, 2023
ljharb
left a comment
ljharb
left a comment
Member
There was a problem hiding this comment.
Can you please add tests covering this?
Comment on lines
+259
to
+260
| return config.some(c => ( | ||
| filename.includes(value.substr(0, 2) === './' ? value.replace('.', process.cwd()) : value) |
Member
There was a problem hiding this comment.
where does value come from here?
also, let's use slice over substr.
| const deps = getDependencies(context, options.packageDir) || extractDepFields({}); | ||
|
|
||
| const depsOptions = { | ||
| allowIgnoreImports: testIgnoreImports(options.ignoreImports, filename) !== false, |
Member
There was a problem hiding this comment.
Suggested change
| allowIgnoreImports: testIgnoreImports(options.ignoreImports, filename) !== false, | |
| ignoreImports: testIgnoreImports(options.ignoreImports, filename) !== false, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix : #2400
Idk how to use globs here, so it's no glob, and support
./for rootDir