Skip to content

Commit 9b47889

Browse files
authored
build: enable symbols, generate artifact with symbols (#332)
1 parent 194e764 commit 9b47889

4 files changed

Lines changed: 17 additions & 2 deletions

File tree

.github/actions/package/action.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,14 @@ runs:
6161
if-no-files-found: error
6262
compression-level: 0
6363

64+
- name: Upload symbols artifact
65+
uses: actions/upload-artifact@v4
66+
with:
67+
name: helium-${{ steps.version.outputs.version }}-${{ env.ARCH }}-symbols
68+
path: build/release/helium-${{ steps.version.outputs.version }}-${{ env.ARCH }}_symbols.zip
69+
if-no-files-found: error
70+
compression-level: 0
71+
6472
- name: Upload .deb artifact
6573
uses: actions/upload-artifact@v4
6674
with:

docker/package.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ RUN echo 'debconf debconf/frontend select Noninteractive' | debconf-set-selectio
88
RUN apt -y update && apt -y upgrade
99

1010
## Install system dependencies
11-
RUN apt -y install binutils elfutils desktop-file-utils dpkg dpkg-dev fakeroot file git imagemagick wget xz-utils pv curl jq python3 zsync gnupg perl make liblocale-gettext-perl
11+
RUN apt -y install binutils elfutils desktop-file-utils dpkg dpkg-dev fakeroot file git imagemagick wget xz-utils pv curl jq python3 zip zsync gnupg perl make liblocale-gettext-perl
1212

1313
## Install Chromium runtime libraries for debbuild resolution
1414
RUN apt -y install --no-install-recommends \

flags.linux.gn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
is_official_build=true
2-
symbol_level=0
2+
symbol_level=1
33
disable_fieldtrial_testing_config=true
44
blink_enable_generated_code_formatting=false
55
blink_symbol_level=0

scripts/package.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,13 @@ cp "$_root_dir/package/helium-wrapper.sh" "$_tarball_dir/helium-wrapper"
6464
wait
6565
(cd "$_tarball_dir" && ln -sf helium chrome)
6666

67+
_syms_zip="$_release_dir/${_release_name}_symbols.zip"
68+
rm -f "$_syms_zip"
69+
find "$_tarball_dir" -type f -exec file {} + \
70+
| awk -F: '/ELF/ {print $1}' \
71+
| sed "s|^$_tarball_dir/||" \
72+
| (cd "$_build_dir/src/out/Default" && zip -q "$_syms_zip" -@)
73+
6774
if command -v eu-strip >/dev/null 2>&1; then
6875
_strip_cmd=eu-strip
6976
else

0 commit comments

Comments
 (0)