fix: cron PATH and persistent crontab for devcontainer

Two issues fixed:

1. cron PATH: cron daemon uses minimal PATH (/usr/sbin:/usr/bin:...)
   which doesn't include codebuddy at /home/linuxbrew/.linuxbrew/bin.
   run-loop.sh now exports full PATH at the top.

2. Persistent crontab: crontab is now written to
   /root/.local/share/loop-crontab (persistent path).
   rc.local loads it on container boot.
   install-cron.sh writes to both persistent file and live crontab.
   start-loops.sh loads from persistent file on startup.

Author: imroc

.codebuddy/scripts/install-cron.sh

@@ -2,7 +2,9 @@
 #
 # Install cron job for Loop Engineering
 # Runs all 5 loops sequentially once daily at 01:00 (Beijing time, UTC+8).
-# Loops run in order: upstream-sync -> dependency-upgrade -> ci-fix -> issue-triage -> pr-review
+#
+# The crontab is written to a persistent path (/root/.local/share/loop-crontab)
+# so it survives container restarts. rc.local loads it on boot.
 #
 # Usage: ./install-cron.sh
 # To uninstall: ./install-cron.sh --remove
@@ -12,11 +14,14 @@ set -euo pipefail
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 RUN_SCRIPT="${SCRIPT_DIR}/run-loop.sh"
 MARKER="# loop-engineering-req"
+PERSIST_DIR="/root/.local/share"
+PERSIST_FILE="${PERSIST_DIR}/loop-crontab"
 
-# Remove existing loop cron jobs
+# Remove existing loop cron jobs from current crontab
 remove_existing() {
   crontab -l 2>/dev/null | grep -v "$MARKER" | crontab - 2>/dev/null || true
-  echo "Removed existing loop cron jobs."
+  rm -f "$PERSIST_FILE"
+  echo "Removed loop cron jobs."
 }
 
 if [[ "${1:-}" == "--remove" ]]; then
@@ -44,17 +49,23 @@ fi
 
 remove_existing
 
-# Add cron job — runs all loops sequentially at 01:00 Beijing time
-# Cron uses system local timezone — ensure server is in CST/Asia-Shanghai
-(
-  crontab -l 2>/dev/null || true
-  echo "$MARKER"
-  echo "0 1 * * * ${RUN_SCRIPT} all $MARKER"
-) | crontab -
+# Build the crontab content: keep existing non-loop entries + add loop entry
+EXISTING=$(crontab -l 2>/dev/null | grep -v "$MARKER" || true)
+CRONTAB_CONTENT="${EXISTING}
+${MARKER}
+0 1 * * * ${RUN_SCRIPT} all ${MARKER}"
+
+# Write to persistent path (survives container restart, loaded by rc.local)
+mkdir -p "$PERSIST_DIR"
+echo "$CRONTAB_CONTENT" > "$PERSIST_FILE"
+
+# Apply immediately
+echo "$CRONTAB_CONTENT" | crontab -
 
 echo "Installed loop cron job (daily, Beijing time):"
 echo "  01:00  all (upstream-sync -> dependency-upgrade -> ci-fix -> issue-triage -> pr-review)"
 echo ""
+echo "Persistent crontab: $PERSIST_FILE (auto-loaded by rc.local on container restart)"
 echo "Logs: \$LOOP_LOG_DIR (default: /tmp/loop-logs/)"
 echo "Uninstall: ${SCRIPT_DIR}/install-cron.sh --remove"
 echo ""

.codebuddy/scripts/run-loop.sh

@@ -15,6 +15,14 @@
 
 set -euo pipefail
 
+# cron has a minimal PATH — set full PATH so codebuddy, gh, go, etc. are found
+export PATH="/root/.linuxbrew/bin:/root/.linuxbrew/sbin:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/root/.bin:/root/.local/bin:/root/.cargo/bin:/root/go/bin:/root/.krew/bin:/root/.fzf/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
+
+# Also load NVM, Cargo, Go env if available
+export HOME="${HOME:-/root}"
+export GOPATH="${GOPATH:-/root/go}"
+[ -f /root/.cargo/env ] && . /root/.cargo/env 2>/dev/null || true
+
 LOOP_TYPE="${1:?Usage: run-loop.sh <ci-fix|issue-triage|pr-review|dependency-upgrade|upstream-sync|all>}"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/../.." && pwd)"

.codebuddy/scripts/start-loops.sh

@@ -1,18 +1,14 @@
 #!/usr/bin/env bash
 #
 # Start Loop Engineering — call this on container/host startup
-# Starts cron daemon (if not running) and installs loop crontab.
+# Starts cron daemon (if not running) and loads persistent crontab.
 #
 # Usage: .codebuddy/scripts/start-loops.sh
-#
-# To auto-start on container boot, add to your entrypoint or profile:
-#   /data/git/req/.codebuddy/scripts/start-loops.sh
-# Or add to ~/.bashrc / /etc/profile.d/
 
 set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-REPO_DIR="$(cd "$SCRIPT_DIR/../.." && pwd)"
+PERSIST_FILE="/root/.local/share/loop-crontab"
 
 # 1. Ensure cron daemon is running
 if ! pgrep -x cron >/dev/null 2>&1; then
@@ -30,13 +26,19 @@ else
     echo "Cron daemon already running."
 fi
 
-# 2. Install loop crontab
-echo "Installing loop crontab..."
-"$SCRIPT_DIR/install-cron.sh"
+# 2. Load persistent crontab if it exists
+if [ -f "$PERSIST_FILE" ]; then
+    echo "Loading crontab from $PERSIST_FILE..."
+    crontab "$PERSIST_FILE"
+    echo "Crontab loaded."
+else
+    echo "No persistent crontab found at $PERSIST_FILE"
+    echo "Run: ${SCRIPT_DIR}/install-cron.sh to create one."
+fi
 
 # 3. Verify
 echo ""
-echo "Loop Engineering is active."
-echo "Cron daemon: $(pgrep -x cron >/dev/null && echo 'running' || echo 'NOT running')"
-echo "Crontab:"
+echo "Loop Engineering status:"
+echo "  Cron daemon: $(pgrep -x cron >/dev/null && echo 'running' || echo 'NOT running')"
+echo "  Crontab:"
 crontab -l 2>/dev/null | grep "loop-engineering-req" || echo "  (no loop entries found)"