Skip to content

Commit b2994f1

Browse files
Remove outdated TODO as the issue is fixed (#271)
1 parent 6add8aa commit b2994f1

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/main/java/io/iworkflow/core/StateDecision.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,6 @@ public static <I> StateDecision forceCompleteIfInternalChannelEmptyOrElse(final
8484
* Atomically force complete the workflow if internal channel is empty, otherwise trigger the state movements from the current thread
8585
* This is important for use case that needs to ensure all the messages in the channel are processed before completing the workflow, otherwise messages will be lost.
8686
* Without this atomic API, if user just check the channel emptiness in the State APIs, the channel may receive new messages during the execution of state APIs
87-
* <br>
88-
* Note that today this doesn't cover the case that internal messages are published from other State APIs yet. It's only for internal messages published from RPCs.
89-
* If you do want to use other State APIs to publish messages to the channel at the same time, you can use persistence locking to ensure only the State APIs are not executed
90-
* in parallel. See more in TODO https://github.com/indeedeng/iwf/issues/289
9187
*
9288
* @param completionOutput the output of workflow completion
9389
* @param internalChannelName the internal channel name for checking emptiness

0 commit comments

Comments
 (0)