ci(release): tolerate forced preview latest tags

Author: iexitdev

.github/workflows/publish.yml

@@ -172,7 +172,9 @@ jobs:
 
             if [ "${CURRENT_LATEST}" = "${PACKAGE_VERSION}" ]; then
               echo "Removing unintended latest tag from ${WORKSPACE_NAME}@${PACKAGE_VERSION}"
-              npm dist-tag rm "${WORKSPACE_NAME}" latest
+              if ! npm dist-tag rm "${WORKSPACE_NAME}" latest; then
+                echo "::warning::npm did not allow removing latest from ${WORKSPACE_NAME}. This is expected for a new package with no stable version yet; release verification will fail if a stable latest was overwritten."
+              fi
             else
               echo "Leaving ${WORKSPACE_NAME} latest tag unchanged (${CURRENT_LATEST:-missing})."
             fi

scripts/check-npm-publish-state.mjs

@@ -11,7 +11,7 @@ export const readJson = async (filePath) =>
 export const npmViewPackage = ({ name, version }) => {
   const result = spawnSync(
     "npm",
-    ["view", `${name}@${version}`, "version", "dist-tags", "--json"],
+    ["view", `${name}@${version}`, "version", "dist-tags", "versions", "--json"],
     {
       encoding: "utf8"
     }
@@ -36,14 +36,16 @@ const normalizeNpmView = (viewResult) => {
     return {
       distTags: {},
       published: false,
-      version: undefined
+      version: undefined,
+      versions: []
     };
   }
 
   return {
     distTags: viewResult.value?.["dist-tags"] ?? {},
     published: true,
-    version: viewResult.value?.version
+    version: viewResult.value?.version,
+    versions: viewResult.value?.versions ?? []
   };
 };
 
@@ -71,11 +73,21 @@ export const buildNpmPublishState = async ({
     );
     const taggedVersion = viewResult.distTags[distTag];
     const latestVersion = viewResult.distTags.latest;
+    const hasStableVersion = viewResult.versions.some(
+      (publishedVersion) => !publishedVersion.includes("-")
+    );
     const hasUnexpectedLatestTag =
       packageInfo.publishInBeta &&
       distTag !== "latest" &&
       version.includes("-") &&
-      latestVersion === version;
+      latestVersion === version &&
+      hasStableVersion;
+    const hasForcedPreviewLatestTag =
+      packageInfo.publishInBeta &&
+      distTag !== "latest" &&
+      version.includes("-") &&
+      latestVersion === version &&
+      !hasStableVersion;
 
     let status = "pass";
     const expected = packageInfo.publishInBeta
@@ -95,6 +107,8 @@ export const buildNpmPublishState = async ({
     entries.push({
       distTag,
       expected,
+      hasForcedPreviewLatestTag,
+      hasStableVersion,
       name: packageInfo.name,
       publishInBeta: packageInfo.publishInBeta === true,
       published: viewResult.published,
@@ -142,11 +156,21 @@ const formatState = (state) => {
     return `- ${entry.name}@${entry.version}: ${entry.status} (${publishedText}, ${tagText}${latestText}; expected ${entry.expected})`;
   });
 
+  const forcedLatestRows = state.entries
+    .filter((entry) => entry.hasForcedPreviewLatestTag)
+    .map(
+      (entry) =>
+        `- ${entry.name}: npm keeps latest=${entry.version} because no stable version has been published yet.`
+    );
+
   return [
     `NPM publish state: ${state.status}`,
     `Version: ${state.version}`,
     `Dist-tag: ${state.distTag}`,
-    ...rows
+    ...rows,
+    ...(forcedLatestRows.length > 0
+      ? ["Preview latest-tag notes:", ...forcedLatestRows]
+      : [])
   ].join("\n");
 };
 

scripts/check-npm-publish-state.test.mjs

@@ -37,7 +37,8 @@ const createNpmView = (publishedPackages) => async ({ name, version }) => {
     exists: true,
     value: {
       "dist-tags": value.distTags ?? { next: version },
-      version: value.version ?? version
+      version: value.version ?? version,
+      versions: value.versions ?? [value.version ?? version]
     }
   };
 };
@@ -111,7 +112,8 @@ describe("npm publish state checker", () => {
       manifest,
       npmView: createNpmView({
         "@chart-kit/core": {
-          distTags: { latest: "7.0.0-next.0", next: "7.0.0-next.0" }
+          distTags: { latest: "7.0.0-next.0", next: "7.0.0-next.0" },
+          versions: ["6.12.2", "7.0.0-next.0"]
         },
         "@chart-kit/react-native": {},
         "react-native-chart-kit": {
@@ -129,4 +131,32 @@ describe("npm publish state checker", () => {
       ["@chart-kit/pro", "pass"]
     ]);
   });
+
+  it("allows npm's forced latest tag when a scoped preview package has no stable version yet", async () => {
+    const state = await buildNpmPublishState({
+      distTag: "next",
+      manifest,
+      npmView: createNpmView({
+        "@chart-kit/core": {
+          distTags: { latest: "7.0.0-next.0", next: "7.0.0-next.0" },
+          versions: ["7.0.0-next.0"]
+        },
+        "@chart-kit/react-native": {},
+        "react-native-chart-kit": {
+          distTags: { latest: "6.12.2", next: "7.0.0-next.0" },
+          versions: ["6.12.2", "7.0.0-next.0"]
+        }
+      }),
+      version: "7.0.0-next.0"
+    });
+
+    expect(state.status).toBe("complete");
+    expect(state.entries.map((entry) => [entry.name, entry.status])).toEqual([
+      ["@chart-kit/core", "pass"],
+      ["@chart-kit/react-native", "pass"],
+      ["react-native-chart-kit", "pass"],
+      ["@chart-kit/pro", "pass"]
+    ]);
+    expect(state.entries[0].hasForcedPreviewLatestTag).toBe(true);
+  });
 });