ci(release): clean prerelease latest dist-tags

Author: iexitdev

.github/workflows/publish.yml

@@ -154,6 +154,34 @@ jobs:
           NPM_TAG: ${{ steps.package.outputs.npm_tag }}
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
+      - name: Remove prerelease latest dist-tags
+        run: |
+          if [ "${NPM_TAG}" = "latest" ] || [[ "${PACKAGE_VERSION}" != *-* ]]; then
+            echo "No prerelease latest tag cleanup needed."
+            exit 0
+          fi
+
+          for PACKAGE_DIR in $(node scripts/list-release-packages.mjs --publishable); do
+            PACKAGE_JSON="${PACKAGE_DIR}/package.json"
+            if [ "${PACKAGE_DIR}" = "." ]; then
+              PACKAGE_JSON="package.json"
+            fi
+
+            WORKSPACE_NAME=$(node -p "require('./${PACKAGE_JSON}').name")
+            CURRENT_LATEST=$(npm dist-tag ls "${WORKSPACE_NAME}" | awk '/^latest:/ {print $2}')
+
+            if [ "${CURRENT_LATEST}" = "${PACKAGE_VERSION}" ]; then
+              echo "Removing unintended latest tag from ${WORKSPACE_NAME}@${PACKAGE_VERSION}"
+              npm dist-tag rm "${WORKSPACE_NAME}" latest
+            else
+              echo "Leaving ${WORKSPACE_NAME} latest tag unchanged (${CURRENT_LATEST:-missing})."
+            fi
+          done
+        env:
+          NPM_TAG: ${{ steps.package.outputs.npm_tag }}
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+          PACKAGE_VERSION: ${{ steps.package.outputs.version }}
+
       - name: Verify npm registry publish state
         run: npm run release:publish:status -- --strict
 

scripts/check-npm-publish-state.mjs

@@ -70,6 +70,12 @@ export const buildNpmPublishState = async ({
       await npmView({ name: packageInfo.name, version })
     );
     const taggedVersion = viewResult.distTags[distTag];
+    const latestVersion = viewResult.distTags.latest;
+    const hasUnexpectedLatestTag =
+      packageInfo.publishInBeta &&
+      distTag !== "latest" &&
+      version.includes("-") &&
+      latestVersion === version;
 
     let status = "pass";
     const expected = packageInfo.publishInBeta
@@ -80,6 +86,8 @@ export const buildNpmPublishState = async ({
       status = "missing";
     } else if (packageInfo.publishInBeta && taggedVersion !== version) {
       status = "wrong-dist-tag";
+    } else if (hasUnexpectedLatestTag) {
+      status = "unexpected-latest-tag";
     } else if (!packageInfo.publishInBeta && viewResult.published) {
       status = "unexpected-published";
     }
@@ -92,6 +100,7 @@ export const buildNpmPublishState = async ({
       published: viewResult.published,
       status,
       taggedVersion,
+      latestVersion,
       version,
       visibleVersion: viewResult.version
     });
@@ -125,9 +134,12 @@ const formatState = (state) => {
     const tagText = entry.taggedVersion
       ? `${entry.distTag}=${entry.taggedVersion}`
       : `${entry.distTag}=<missing>`;
+    const latestText = entry.latestVersion
+      ? `, latest=${entry.latestVersion}`
+      : "";
     const publishedText = entry.published ? "published" : "not published";
 
-    return `- ${entry.name}@${entry.version}: ${entry.status} (${publishedText}, ${tagText}; expected ${entry.expected})`;
+    return `- ${entry.name}@${entry.version}: ${entry.status} (${publishedText}, ${tagText}${latestText}; expected ${entry.expected})`;
   });
 
   return [

scripts/check-npm-publish-state.test.mjs

@@ -104,4 +104,29 @@ describe("npm publish state checker", () => {
       ["@chart-kit/pro", "unexpected-published"]
     ]);
   });
+
+  it("fails when a prerelease package is accidentally tagged latest", async () => {
+    const state = await buildNpmPublishState({
+      distTag: "next",
+      manifest,
+      npmView: createNpmView({
+        "@chart-kit/core": {
+          distTags: { latest: "7.0.0-next.0", next: "7.0.0-next.0" }
+        },
+        "@chart-kit/react-native": {},
+        "react-native-chart-kit": {
+          distTags: { latest: "6.12.2", next: "7.0.0-next.0" }
+        }
+      }),
+      version: "7.0.0-next.0"
+    });
+
+    expect(state.status).toBe("failed");
+    expect(state.entries.map((entry) => [entry.name, entry.status])).toEqual([
+      ["@chart-kit/core", "unexpected-latest-tag"],
+      ["@chart-kit/react-native", "pass"],
+      ["react-native-chart-kit", "pass"],
+      ["@chart-kit/pro", "pass"]
+    ]);
+  });
 });