Fix PHPCS errors and configure exclusions for tests/adapters

Author: pfefferle

includes/class-rest-controller.php

@@ -405,11 +405,14 @@ protected function get_timeline( $request, $user_id ) {
 
 		// Sort items by published date (newest first).
 		$items = $result['items'];
-		\usort( $items, function ( $a, $b ) {
-			$date_a = isset( $a['published'] ) ? \strtotime( $a['published'] ) : 0;
-			$date_b = isset( $b['published'] ) ? \strtotime( $b['published'] ) : 0;
-			return $date_b - $date_a;
-		} );
+		\usort(
+			$items,
+			function ( $a, $b ) {
+				$date_a = isset( $a['published'] ) ? \strtotime( $a['published'] ) : 0;
+				$date_b = isset( $b['published'] ) ? \strtotime( $b['published'] ) : 0;
+				return $date_b - $date_a;
+			}
+		);
 
 		// Apply limit.
 		$items = \array_slice( $items, 0, $args['limit'] );

phpcs.xml

@@ -21,5 +21,28 @@
 	<rule ref="WordPress">
 		<exclude name="Universal.Operators.DisallowShortTernary" />
 	</rule>
-	<rule ref="VariableAnalysis"/>
+	<rule ref="VariableAnalysis">
+		<exclude-pattern>*/includes/class-adapter.php</exclude-pattern>
+		<exclude-pattern>*/includes/adapters/*</exclude-pattern>
+		<exclude-pattern>*/tests/*</exclude-pattern>
+	</rule>
+	<rule ref="Generic.CodeAnalysis.UnusedFunctionParameter">
+		<exclude-pattern>*/includes/class-adapter.php</exclude-pattern>
+		<exclude-pattern>*/includes/adapters/*</exclude-pattern>
+	</rule>
+	<rule ref="Generic.Formatting.MultipleStatementAlignment">
+		<exclude-pattern>*/tests/*</exclude-pattern>
+	</rule>
+	<rule ref="WordPress.Files.FileName">
+		<exclude-pattern>*/tests/*</exclude-pattern>
+	</rule>
+	<rule ref="Generic.Files.OneObjectStructurePerFile">
+		<exclude-pattern>*/tests/*</exclude-pattern>
+	</rule>
+	<rule ref="Squiz.Commenting">
+		<exclude-pattern>*/tests/*</exclude-pattern>
+	</rule>
+	<rule ref="WordPress.Security.EscapeOutput">
+		<exclude-pattern>*/tests/*</exclude-pattern>
+	</rule>
 </ruleset>

tests/phpunit/bootstrap.php

@@ -29,7 +29,7 @@
  * Manually load the plugin being tested.
  */
 function _manually_load_plugin() {
-	require dirname( dirname( dirname( __FILE__ ) ) ) . '/microsub.php';
+	require dirname( __DIR__, 2 ) . '/microsub.php';
 }
 
 tests_add_filter( 'muplugins_loaded', '_manually_load_plugin' );