Skip to content

Added customizable header formats#184

Open
volker-holz wants to merge 2 commits into
indrimuska:masterfrom
cyan-it:master
Open

Added customizable header formats#184
volker-holz wants to merge 2 commits into
indrimuska:masterfrom
cyan-it:master

Conversation

@volker-holz
Copy link
Copy Markdown

No description provided.

@shaunbowe
Copy link
Copy Markdown

shaunbowe commented Jun 7, 2017

I was just about to add this same feature. Any idea on the status of merging these @indrimuska?

@shaunbowe
Copy link
Copy Markdown

@volker-holz the names for the properties don't seem to match the view they are used in. I would expect the DayView to use daysHeaderFormat, instead it uses minutesHeaderFormat. The ultimate values seem correct but the names of the variables don't match the views they are used in.

@volker-holz
Copy link
Copy Markdown
Author

volker-holz commented Jun 8, 2017

@shaunbowe that seemed counter-intuitive for me too in the first place - but if you take a look at the Views though you will notice that the DayView uses the hoursFormat - I wanted the [x]HeaderFormat to have a somehow corresponding name in the provider, that's why I picked "hoursHeaderFormat". You might translate it to "the format of the header when picking hours" Do you get what I'm out for? Does it make sense that way?

@shaunbowe
Copy link
Copy Markdown

It seems strange still but I agree it is consistent with the original code and changing it would have been more confusing.

@indrimuska
Copy link
Copy Markdown
Owner

Hi guys, sorry for the late response.
This is a very interesting feature, could you please create a plunker to see this in action and updated the README file properly? After that I think we can go for the merge.
Thanks for the time you've spent.

@indrimuska
Copy link
Copy Markdown
Owner

FYI it doesn't make sense to include the distributions files in this merge as they will be regenerated after each release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants