remove duplicates when creating FunctionDefinition

Author: majosm

arraycontext/impl/pytato/outline.py

@@ -204,13 +204,14 @@ def __call__(self, *args: Any, **kwargs: Any) -> ArrayOrContainer:
             unpacked_prefixed_output = _unpack_output(prefixed_output)
             if isinstance(unpacked_prefixed_output, pt.Array):
                 unpacked_prefixed_output = {"_": unpacked_prefixed_output}
+            unpacked_prefixed_output = pt.transform.Deduplicator()(
+                pt.make_dict_of_named_arrays(unpacked_prefixed_output))
 
             prefixed_placeholders = frozenset(
                 arg_id_to_prefixed_placeholder.values())
 
             found_placeholders = frozenset({
-                arg for arg in pt.transform.InputGatherer()(
-                    pt.make_dict_of_named_arrays(unpacked_prefixed_output))
+                arg for arg in pt.transform.InputGatherer()(unpacked_prefixed_output)
                 if isinstance(arg, pt.Placeholder)})
 
             extra_placeholders = found_placeholders - prefixed_placeholders
@@ -227,10 +228,12 @@ def __call__(self, *args: Any, **kwargs: Any) -> ArrayOrContainer:
             ret_type = pt.function.ReturnType.ARRAY
         else:
             ret_type = pt.function.ReturnType.DICT_OF_ARRAYS
+        unpacked_output = pt.transform.Deduplicator()(
+            pt.make_dict_of_named_arrays(unpacked_output))
 
         used_placeholders = frozenset({
             arg for arg in pt.transform.InputGatherer()(
-                pt.make_dict_of_named_arrays(unpacked_output))
+                unpacked_output)
             if isinstance(arg, pt.Placeholder)})
 
         call_bindings = {
@@ -245,7 +248,7 @@ def __call__(self, *args: Any, **kwargs: Any) -> ArrayOrContainer:
         func_def = pt.function.FunctionDefinition(
             parameters=frozenset(call_bindings.keys()),
             return_type=ret_type,
-            returns=immutabledict(unpacked_output),
+            returns=immutabledict(unpacked_output._data),
             tags=self.tags,
         )