Fix move_dims bug when moving to parameter space#12
Merged
Conversation
inducer
force-pushed
the
fix-anonymous-parameter-names
branch
from
July 16, 2026 18:36
5027273 to
07a59a4
Compare
inducer
force-pushed
the
fix-anonymous-parameter-names
branch
from
July 16, 2026 18:45
07a59a4 to
1b2c606
Compare
inducer
enabled auto-merge (rebase)
July 16, 2026 18:45
Owner
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISL objects must have named parameter dimensions. Current namedisl
move_dimsbehavior blindly moves requested dimensions into parameter space upon request resulting in an error likeislpy._isl.Error: call to isl_set_set_dim_name failed: spaces don't match in /project/isl/isl_type_check_equal_space_templ.c:21from islpy.This PR fixes the bug by explicitly naming dimensions in the underlying ISL object if the destination is
DimType.param. Also adds a regression test.