Ruff: enable TC

Author: inducer

doc/codegen.rst

@@ -4,3 +4,27 @@ Code Generation
 .. automodule:: sumpy.codegen
 .. automodule:: sumpy.assignment_collection
 .. automodule:: sumpy.cse
+
+References
+----------
+
+This is only here because Sphinx (the documentation tool) fails to resolve these
+references properly.
+
+.. currentmodule:: lp
+
+.. class:: TranslationUnit
+
+    See :class:`loopy.TranslationUnit`.
+
+.. currentmodule:: sp
+
+.. class:: Expr
+
+    See :class:`sympy.core.expr.Expr`.
+
+.. currentmodule:: np
+
+.. class:: ndarray
+
+    See :class:`numpy.ndarray`.

pyproject.toml

@@ -91,6 +91,7 @@ extend-select = [
     "SIM", # flake8-simplify
     "UP",  # pyupgrade
     "W",   # pycodestyle
+    "TC",
 ]
 extend-ignore = [
     "C90",  # McCabe complexity

sumpy/__init__.py

@@ -24,9 +24,8 @@
 """
 
 import os
-from collections.abc import Hashable
+from typing import TYPE_CHECKING
 
-import loopy as lp
 from pytools.persistent_dict import WriteOncePersistentDict
 
 from sumpy.e2e import (
@@ -44,6 +43,12 @@
 from sumpy.version import VERSION_TEXT
 
 
+if TYPE_CHECKING:
+    from collections.abc import Hashable
+
+    import loopy as lp
+
+
 __all__ = [
     "P2P",
     "E2EFromCSR",

sumpy/expansion/__init__.py

@@ -25,18 +25,23 @@
 
 import logging
 from abc import ABC, abstractmethod
-from collections.abc import Hashable, Sequence
-from typing import Any, ClassVar
+from typing import TYPE_CHECKING, Any, ClassVar
 
-import loopy as lp
 import pymbolic.primitives as prim
 from pytools import memoize_method
 
 import sumpy.symbolic as sym
-from sumpy.kernel import Kernel
 from sumpy.tools import add_mi
 
 
+if TYPE_CHECKING:
+    from collections.abc import Hashable, Sequence
+
+    import loopy as lp
+
+    from sumpy.kernel import Kernel
+
+
 logger = logging.getLogger(__name__)
 
 

sumpy/expansion/diff_op.py

@@ -26,9 +26,9 @@
 """
 
 import logging
-from collections.abc import Mapping, Sequence
 from dataclasses import dataclass
 from itertools import accumulate
+from typing import TYPE_CHECKING
 
 import numpy as np
 import sympy as sp
@@ -41,6 +41,10 @@
 from sumpy.tools import add_mi
 
 
+if TYPE_CHECKING:
+    from collections.abc import Mapping, Sequence
+
+
 logger = logging.getLogger(__name__)
 
 __doc__ = """

sumpy/expansion/loopy.py

@@ -24,7 +24,7 @@
 """
 
 import logging
-from collections.abc import Sequence
+from typing import TYPE_CHECKING
 
 import numpy as np
 
@@ -33,11 +33,16 @@
 
 import sumpy.symbolic as sym
 from sumpy.assignment_collection import SymbolicAssignmentCollection
-from sumpy.expansion import ExpansionBase
-from sumpy.kernel import Kernel
 from sumpy.tools import gather_loopy_arguments, gather_loopy_source_arguments
 
 
+if TYPE_CHECKING:
+    from collections.abc import Sequence
+
+    from sumpy.expansion import ExpansionBase
+    from sumpy.kernel import Kernel
+
+
 logger = logging.getLogger(__name__)
 
 

sumpy/expansion/m2l.py

@@ -1076,8 +1076,8 @@ def loopy_translation_classes_dependent_data(tgt_expansion, src_expansion,
     for i in range(len(insns)):
         insn = insns[i]
         if isinstance(insn, lp.Assignment) and \
-                cast(p.Variable, insn.assignee).name.startswith(vec_name):
-            idx = int(cast(p.Variable, insn.assignee).name[len(vec_name):])
+                cast("p.Variable", insn.assignee).name.startswith(vec_name):
+            idx = int(cast("p.Variable", insn.assignee).name[len(vec_name):])
             insns[i] = lp.Assignment(
                 assignee=data[idx],
                 expression=insn.expression,

sumpy/kernel.py

@@ -28,7 +28,6 @@
 from typing import TYPE_CHECKING, ClassVar
 
 import numpy as np
-import sympy as sp
 
 import loopy as lp
 import pymbolic.primitives as prim
@@ -42,6 +41,8 @@
 
 
 if TYPE_CHECKING:
+    import sympy as sp
+
     from sumpy.expansion.diff_op import LinearPDESystemOperator
 
 

sumpy/tools.py

@@ -40,7 +40,6 @@
 import numpy as np
 
 import loopy as lp
-import pyopencl as cl
 from pymbolic.mapper import WalkMapper
 from pytools import memoize_method
 from pytools.tag import Tag, tag_dataclass
@@ -52,6 +51,7 @@
     import numpy
 
     import pyopencl
+    import pyopencl as cl
 
     from sumpy.kernel import Kernel
 

sumpy/toys.py

@@ -1,7 +1,5 @@
 from __future__ import annotations
 
-from sumpy.expansion.m2l import M2LTranslationClassFactoryBase
-
 
 __copyright__ = """
 Copyright (C) 2017 Andreas Kloeckner
@@ -28,7 +26,6 @@
 THE SOFTWARE.
 """
 
-from collections.abc import Sequence
 from functools import partial
 from numbers import Number
 from typing import TYPE_CHECKING
@@ -39,8 +36,11 @@
 
 
 if TYPE_CHECKING:
+    from collections.abc import Sequence
+
     import pyopencl
 
+    from sumpy.expansion.m2l import M2LTranslationClassFactoryBase
     from sumpy.kernel import Kernel
     from sumpy.visualization import FieldPlotter