IGN-14665: Update for Ignition 8.3.3#4
Merged
thirdgen88 merged 7 commits intoJan 30, 2026
Conversation
ia-eknorr
approved these changes
Jan 13, 2026
Collaborator
ia-eknorr
left a comment
There was a problem hiding this comment.
This all looks good. I verified each commit as requested where applicable. I did a full test of upgrading the helm release from 8.3.0 (using chart version 0.2.0) to 8.3.2 (using chart version 0.2.1), which spun up successfully.
|
This looks good in QA as well. We've verified upgrades of redundant 0.2.0 (8.3.0) deployments to the latest 0.2.1 (8.3.3) chart with active Perspective and Vision clients (referencing tags, active alarms, etc). Failover occurs as expected and data can be seen to be in sync between primary and backup, before and after failover. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Background
Upgrading from one version to the next in a redundant configuration had previously required manual intervention to fail-over the active Primary to the Backup in order for the Backup to become ready and allow the rollout of the StatefulSet to continue. This PR will set the default AppVersion for the chart to 8.3.3 and incorporate an adjustment to this behavior to allow for automatic upgrades of a redundant pair.
⚙️ Changes
9944e22 chore: bump appVersion to 8.3.3
8f98b8f chore: bump helm-unittest plugin to 1.0.3
d46e269 feat: add PR workflow artifacting
75ca5f6 fix: correct usage info on redundant health check
b301d85 fix: Update redundant health check accepted states
cadde71 chore: bump appVersion to 8.3.2
b713746 fix: correct application of supplemental pod labels
For the redundant health check, we're now accepting
Good,OutOfDateandIncompatibleas valid values for the readiness probe (when in a redundant configuration viagateway.redundancy.enabled=true). This should help both situations where the backup gateway becomes temporarily out-of-sync or during upgrades where the "Incompatible (Platform)" status is observed on the Backup gateway.📝 Reviewer Notes
I've got the commits broken out, best to review them individually first.
☑️ QA Notes
We'll want to test a redundant base 8.3.0 configuration using chart version 0.2.0. We should setup some tags and stateful data that is sync'd over redundancy and then test an upgrade to the new chart version. Since the changes are only in the redundant-health-check.sh script that is applied when
gateway.redundancy.enabled=true, the test scope shouldn't have to worry much about a standalone upgrade.