eloquent controllers: use [static::class, ] as controller method refe…#1011
Open
afk11 wants to merge 1 commit into
Open
eloquent controllers: use [static::class, ] as controller method refe…#1011afk11 wants to merge 1 commit into
afk11 wants to merge 1 commit into
Conversation
…rence for routes. More robust against typos (execution fails with a syntax error) and helps IDE determine what code is being run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a typo in the string format isn't detected until much later, whereas static::class is always correct, and can't be typod without producing compile errors (detected early)
it's also invisible to 'Find Usages' in PhpStorm in the string format, so this helps navigating the project