-
Notifications
You must be signed in to change notification settings - Fork 5
Enhance perf #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Enhance perf #285
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b7c98e4
fix err on mismatching number of params for useCallback in InfiniteTa…
radubrehar 67b1a72
wip
radubrehar e7a4d03
move away from pure React context usage to selector-based usage to av…
radubrehar a723dee
wip
radubrehar 54768d6
fix hover styles sometimes not being removed
radubrehar 2a0de66
update perf test
radubrehar 0708142
update perf baseline
radubrehar d4bd7c1
trigger ci
radubrehar 125758f
update
radubrehar bba3bcc
rerun ci
radubrehar c42fb52
update timeout of tracing tests to default to 10s
radubrehar f6f3ec8
trigger ci
radubrehar 6d9fcd3
trigger ci
radubrehar e574c49
chore: update CI performance baselines [skip ci]
github-actions[bot] 9785a9e
remove old master detail context
radubrehar cd46059
more fixes
radubrehar a9dc92e
update docs
radubrehar 8b7d2b5
more enhancements
radubrehar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,107 @@ | ||
| { | ||
| "tests/table/perf/default:horizontal-scrolling": { | ||
| "scriptingTime": 111.42, | ||
| "renderingTime": 26.61, | ||
| "paintingTime": 8.89, | ||
| "totalTime": 714.34, | ||
| "tests/table/perf/default:horizontal-scrolling with tracing": { | ||
| "scriptingTime": 135.73, | ||
| "renderingTime": 23.92, | ||
| "paintingTime": 8.11, | ||
| "totalTime": 628.45, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/perf/flashing/default:perf should be fine when single click": { | ||
| "scriptingTime": 22.01, | ||
| "renderingTime": 0.48, | ||
| "paintingTime": 0.07, | ||
| "totalTime": 155.95, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/perf/flashing/default:should be able to collapse and expand nodes with no error": { | ||
| "scriptingTime": 163.94, | ||
| "renderingTime": 81.91, | ||
| "paintingTime": 5.63, | ||
| "totalTime": 451.16, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/perf/flashing/default:perf should remain stable for 50 clicks": { | ||
| "scriptingTime": 847.02, | ||
| "renderingTime": 35.58, | ||
| "paintingTime": 28.71, | ||
| "totalTime": 3126.17, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/props/column/column-change:works correctly": { | ||
| "scriptingTime": 39.5, | ||
| "renderingTime": 4.08, | ||
| "paintingTime": 0.88, | ||
| "totalTime": 251.63, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/props/column-pinning/virtualization:should work correctly": { | ||
| "scriptingTime": 162.82, | ||
| "renderingTime": 8.74, | ||
| "paintingTime": 0.9, | ||
| "totalTime": 230.74, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/props/data/basic-add-data:insert data": { | ||
| "scriptingTime": 198.43, | ||
| "renderingTime": 4.35, | ||
| "paintingTime": 1.37, | ||
| "totalTime": 301.11, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/props/data/basic-update:via API should not rerender header": { | ||
| "scriptingTime": 23.61, | ||
| "renderingTime": 2.46, | ||
| "paintingTime": 0.97, | ||
| "totalTime": 221.55, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/props/data/editing/column-editor:should use custom editor when configured": { | ||
| "scriptingTime": 118.99, | ||
| "renderingTime": 32.66, | ||
| "paintingTime": 5.04, | ||
| "totalTime": 628.58, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/props/data/editing/persistEdit:should not persist changes to the id column": { | ||
| "scriptingTime": 56.02, | ||
| "renderingTime": 11.96, | ||
| "paintingTime": 1.26, | ||
| "totalTime": 294.24, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/props/data/editing/persistEdit:should call and wait for async persistEdit correctly": { | ||
| "scriptingTime": 81.64, | ||
| "renderingTime": 20.67, | ||
| "paintingTime": 2.25, | ||
| "totalTime": 575.84, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/props/data/edit-with-delay:on string column": { | ||
| "scriptingTime": 322.51, | ||
| "renderingTime": 24.6, | ||
| "paintingTime": 17.67, | ||
| "totalTime": 4084.08, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/props/filtering/filter-value/client-side:Filters correctly": { | ||
| "scriptingTime": 254.35, | ||
| "renderingTime": 29.37, | ||
| "paintingTime": 7.81, | ||
| "totalTime": 455.72, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/props/data/scrolling:scrolls the table with performance tracing": { | ||
| "scriptingTime": 304.86, | ||
| "renderingTime": 94.59, | ||
| "paintingTime": 49.87, | ||
| "totalTime": 652.31, | ||
| "scriptingTime": 473.23, | ||
| "renderingTime": 141, | ||
| "paintingTime": 57.1, | ||
| "totalTime": 906.55, | ||
| "threshold": 10 | ||
| }, | ||
| "tests/table/props/data/update:clicks update button 30 times with performance tracing": { | ||
| "scriptingTime": 579.33, | ||
| "renderingTime": 36.93, | ||
| "paintingTime": 51.26, | ||
| "totalTime": 3089.28, | ||
| "scriptingTime": 642.03, | ||
| "renderingTime": 43.1, | ||
| "paintingTime": 45.53, | ||
| "totalTime": 3284.21, | ||
| "threshold": 10 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 7 additions & 4 deletions
11
examples/src/pages/tests/datasource/sortinfo-controlled.page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate baseline entry with trailing dot typo
Low Severity
The baselines file contains
"tests/table/perf/default:horizontal-scrolling."(with a trailing dot) which doesn't match any test name. The file already has the correct entry"tests/table/perf/default:horizontal-scrolling"(without trailing dot) and"...horizontal-scrolling with tracing". This orphaned entry will never be matched and may cause confusion about expected baselines.