Dnd improvements, fix flicker on column reorder and release version patch#287
Merged
radubrehar merged 5 commits intomasterfrom Apr 3, 2026
Merged
Dnd improvements, fix flicker on column reorder and release version patch#287radubrehar merged 5 commits intomasterfrom
radubrehar merged 5 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Autofix Details
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: Documentation says default is 'inline' but code defaults to 'proxy'
- I changed the runtime fallback in DragList from 'proxy' to 'inline' so behavior now matches the documented default.
- ✅ Fixed: Debug
background: 'red'left in example code- I removed the leftover
background: 'red'debug style from the example drag proxy render path.
- I removed the leftover
Or push these changes by commenting:
@cursor push 0a59927d9f
Preview (0a59927d9f)
diff --git a/examples/src/pages/tests/table/dnd/dnd-source-target.page.tsx b/examples/src/pages/tests/table/dnd/dnd-source-target.page.tsx
--- a/examples/src/pages/tests/table/dnd/dnd-source-target.page.tsx
+++ b/examples/src/pages/tests/table/dnd/dnd-source-target.page.tsx
@@ -275,7 +275,6 @@
proxyRef={ref}
style={{
position: 'fixed',
- background: 'red',
top: initialRect.top + dy,
left: initialRect.left + dx,
width: initialRect.width,
diff --git a/source/src/components/InfiniteTable/components/draggable/DragList.tsx b/source/src/components/InfiniteTable/components/draggable/DragList.tsx
--- a/source/src/components/InfiniteTable/components/draggable/DragList.tsx
+++ b/source/src/components/InfiniteTable/components/draggable/DragList.tsx
@@ -794,7 +794,7 @@
};
scrollContainer?.addEventListener('scroll', onContainerScroll);
- const dragStrategy = props.dragStrategy ?? 'proxy';
+ const dragStrategy = props.dragStrategy ?? 'inline';
const useProxy = dragStrategy === 'proxy' && !props.renderDragProxy;
const useRenderProxy =
dragStrategy === 'proxy' && !!props.renderDragProxy;This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Refactors core drag-and-drop behavior (proxy rendering and scroll handling) used across lists/headers; regressions could affect drop index calculations, scrolling, and cleanup across many drag interactions.
Overview
Improves
DragListdrag-and-drop behavior by adding a configurabledragStrategy(inlinevs defaultproxy), optional custom proxy hooks (onDragProxySetup/onDragProxyMove) and ReactrenderDragProxy, plus apreserveDragSpaceoption for cross-list drags.Adds an
AutoScrollerand scroll-aware logic (adjustForScroll,DragManager.retriggerMove, expanded list rectangles) to keep drag/drop calculations correct while source/target containers scroll and to prevent scroll feedback loops.Updates the table header and grouping toolbar to explicitly use
dragStrategy="inline", adds new DnD demo pages, tweaks a test to disable tracing, and documents release8.0.2as DnD improvements.Written by Cursor Bugbot for commit 8b61688. This will update automatically on new commits. Configure here.