Skip to content

fix issue requesting previous TXT record if there is no record #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
infinityofspace merged 2 commits into from
Nov 30, 2025
Merged

fix issue requesting previous TXT record if there is no record #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ff36a0
bump version to v1.7.1
infinityofspace Nov 30, 2025
886c8eb
fix issue requesting previous TXT record if there is no record closes…
infinityofspace Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion certbot_dns_duckdns/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
"""Certbot plugin for DNS-01 challenge using DuckDNS."""

__version__ = "v1.7.0"
__version__ = "v1.7.1"
16 changes: 9 additions & 7 deletions certbot_dns_duckdns/cert/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,17 @@ def _perform(self, domain: str, validation_name: str, validation: str) -> None:
txt_values = custom_resolver.resolve(duckdns_domain, "TXT")
else:
txt_values = custom_resolver.query(duckdns_domain, "TXT")
except Exception as e:
raise errors.PluginError(e)

# there should only be one single TXT record
if len(txt_values) != 1:
raise errors.PluginError("issue resoling TXT record")
# there should only be one single TXT record
if len(txt_values) != 1:
raise errors.PluginError("issue resoling TXT record")

# remove the additional quotes around the TXT value
self._old_txt_value = txt_values[0].to_text()[1:-1]
# remove the additional quotes around the TXT value
self._old_txt_value = txt_values[0].to_text()[1:-1]
except dns.resolver.NoAnswer:
self._old_txt_value = ""
except Exception as e:
raise errors.PluginError(e)

try:
self._get_duckdns_client().set_txt_record(duckdns_domain, validation)
Expand Down