inline and rename function

Author: alamb

datafusion/expr/src/expr.rs

@@ -642,7 +642,7 @@ pub type SchemaFieldMetadata = std::collections::HashMap<String, String>;
 /// # Returns
 ///
 /// A new `SchemaFieldMetadata` containing only the intersected metadata
-pub fn intersect_for_union<'a>(
+pub fn intersect_metadata_for_union<'a>(
     metadatas: impl IntoIterator<Item = &'a SchemaFieldMetadata>,
 ) -> SchemaFieldMetadata {
     let mut metadatas = metadatas.into_iter();

datafusion/expr/src/logical_plan/plan.rs

@@ -32,7 +32,7 @@ use super::invariants::{
 use super::DdlStatement;
 use crate::builder::{change_redundant_column, unnest_with_options};
 use crate::expr::{
-    intersect_for_union, Placeholder, Sort as SortExpr, WindowFunction,
+    intersect_metadata_for_union, Placeholder, Sort as SortExpr, WindowFunction,
     WindowFunctionParams,
 };
 use crate::expr_rewriter::{
@@ -2802,7 +2802,7 @@ impl Union {
 
                     let mut field =
                         Field::new(name, data_type.clone(), final_is_nullable);
-                    field.set_metadata(intersect_maps(unmerged_metadata));
+                    field.set_metadata(intersect_metadata_for_union(unmerged_metadata));
 
                     (None, Arc::new(field))
                 },
@@ -2896,12 +2896,6 @@ impl Union {
     }
 }
 
-fn intersect_maps<'a>(
-    inputs: impl IntoIterator<Item = &'a HashMap<String, String>>,
-) -> HashMap<String, String> {
-    intersect_for_union(inputs)
-}
-
 // Manual implementation needed because of `schema` field. Comparison excludes this field.
 impl PartialOrd for Union {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {