Skip to content

refactor: replace wiremock with own test harness#453

Merged
crepererum merged 1 commit intomainfrom
crepererum/http-test-harness-rewrite
Apr 15, 2026
Merged

refactor: replace wiremock with own test harness#453
crepererum merged 1 commit intomainfrom
crepererum/http-test-harness-rewrite

Conversation

@crepererum
Copy link
Copy Markdown
Collaborator

Reasons:

  • there are too many layers of types that transfer/modify things
  • we gonna need a test harness that supports TLS/HTTPs
  • we need kinda precise control over which protocols are used to know what we're actually testing here
  • I wanna use something simple, i.e. not a full-blown "we launch a server in the background" magic thing like httpmock

@crepererum crepererum force-pushed the crepererum/http-test-harness-rewrite branch from 723fc89 to 4899b83 Compare April 13, 2026 12:29
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over half of this file is tests (i.e. "test the tester"). The actual mock server implementation is rather simple.

@crepererum crepererum force-pushed the crepererum/http-test-harness-rewrite branch from 4899b83 to 4ee1e2d Compare April 13, 2026 13:16
@crepererum crepererum marked this pull request as ready for review April 13, 2026 13:34
@crepererum crepererum requested a review from a team April 13, 2026 13:34
Copy link
Copy Markdown
Contributor

@Sl1mb0 Sl1mb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@crepererum crepererum added this pull request to the merge queue Apr 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 15, 2026
Reasons:
- there are too many layers of types that transfer/modify things
- we gonna need a test harness that supports TLS/HTTPs
- we need kinda precise control over which protocols are used to know
  what we're actually testing here
- I wanna use something simple, i.e. not a full-blown "we launch a
  server in the background" magic thing like `httpmock`
@crepererum crepererum force-pushed the crepererum/http-test-harness-rewrite branch from 4ee1e2d to 7bee09c Compare April 15, 2026 12:08
@crepererum crepererum enabled auto-merge April 15, 2026 12:08
@crepererum crepererum added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 4e9eac6 Apr 15, 2026
2 checks passed
@crepererum crepererum deleted the crepererum/http-test-harness-rewrite branch April 15, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants