fix(vale): skip gracefully when no Vale binary and no Docker daemon#7472
Open
jstirnaman wants to merge 1 commit into
Open
fix(vale): skip gracefully when no Vale binary and no Docker daemon#7472jstirnaman wants to merge 1 commit into
jstirnaman wants to merge 1 commit into
Conversation
In sandboxed agent sessions (issue #7470) neither execution path in .ci/vale/vale.sh works: the Docker daemon is unavailable and binary downloads from GitHub releases are blocked by the session proxy. The hard failure forced `git commit --no-verify`, bypassing all pre-commit hooks instead of just Vale. - vale.sh: check for a running Docker daemon (docker info), not just the CLI; when neither a v3+ binary nor a daemon is available, warn and exit 0 so other hooks still run. VALE_STRICT=1 turns the skip into a failure. - pr-vale-check.yml: set VALE_STRICT=1 so CI (the authoritative gate) can never skip silently, and update the release download URL to the renamed vale-cli org (errata-ai redirect still works today). - lefthook.yml: point clustered-lint at the clustered .vale.ini instead of the cloud-serverless config (copy-paste error). - Document the sandbox limitation and skip behavior in the vale-linting skill and DOCS-TESTING.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dwz2V5JLtbHjeDhKdusjw2
Contributor
Vale Style Check Results
✅ Check passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #7470 (Problem 1: Vale can't run in sandboxed agent sessions). Problem 2 (
yarn lintdirtyingassets/jsconfig.json) is not addressed here.In sandboxed agent sessions, neither execution path in
.ci/vale/vale.shworks: the Docker daemon is unavailable and binary downloads from GitHub releases are blocked by the session proxy. The hard failure forcedgit commit --no-verify, which bypasses all pre-commit hooks instead of just Vale. Full evaluation and verification details: #7470 (comment).Changes:
.ci/vale/vale.sh— check for a running Docker daemon (docker info), not just the CLI. When neither a v3+ binary nor a daemon is available, warn and exit 0 so other hooks still run.VALE_STRICT=1turns the skip into a failure..github/workflows/pr-vale-check.yml— setVALE_STRICT=1so CI (the authoritative gate) can never skip silently; update the release download URL to the renamedvale-cliorg (theerrata-airedirect still works today).lefthook.yml— pointclustered-lintatcontent/influxdb3/clustered/.vale.iniinstead of the cloud-serverless config (copy-paste error found during config review)..agents/skills/vale-linting/SKILL.md,DOCS-TESTING.md— document the sandbox limitation, the skip behavior, and the "don't use--no-verify" guidance.Verified in an affected sandbox: direct invocation skips with a warning (exit 0),
VALE_STRICT=1fails (exit 1), and a real commit exercised the new path —lint-instructionsskipped Vale with a warning while all other hooks ran normally.Checklist
npx hugo --quiet)🤖 Generated with Claude Code
https://claude.ai/code/session_01Dwz2V5JLtbHjeDhKdusjw2
Generated by Claude Code