feat(inputs.mem): Add extended memory statistics by pvlltvk · Pull Request #18532 · influxdata/telegraf

pvlltvk · 2026-03-15T11:18:31Z

Summary

Add platform-specific extended memory fields behind a collect_extended config option (default: false). Linux provides active_file, inactive_file, active_anon, inactive_anon, unevictable, and percpu fields via /proc/meminfo. Windows provides commit, virtual, physical, and page file counters.

This is a rewrite of the previous closed pull request, #18281, which takes into account all the comments provided: the code has been simplified, current tests have not changed, etc.

Checklist

No AI generated code was used in this PR
AI generated code used in this PR follows the InfluxData Policy on AI-Generated Code Contributions

Related issues

resolves #17925

Add platform-specific extended memory fields behind a `collect_extended` config option (default: false). Linux provides active_file, inactive_file, active_anon, inactive_anon, unevictable, and percpu fields via /proc/meminfo. Windows provides commit, virtual, physical, and page file counters.

srebhan

Thanks for your contribution @pvlltvk! Please find my comments in the code...

srebhan

Thanks @pvlltvk! Some more comments regarding unit-tests...

srebhan · 2026-03-30T12:44:21Z

 	testutil.RequireMetricsEqual(t, expected, acc.GetTelegrafMetrics(), testutil.IgnoreTime())
 }
+
+var linuxBaseFields = map[string]interface{}{


Please define those in the test that uses the fields! This avoids potential side effects and it also makes the test more self-contained.

srebhan · 2026-03-30T12:44:52Z

+		},
+	}
+
+	baseFields := linuxBaseFields


Please define this in the t.Run section to avoid side effects between tests!

srebhan · 2026-03-30T12:45:30Z

+
+			var mps psutil.MockPS
+			defer mps.AssertExpectations(t)
+			var acc testutil.Accumulator


Please define the accumulator directly before using it to minimize the scope of the variable!

srebhan · 2026-03-30T12:46:31Z

+			}
+
+			require.NoError(t, plugin.Init())
+			plugin.platform = "linux"


Why do we need this? The test is only run on Linux, isn't it?

srebhan · 2026-03-30T12:46:59Z

+	}
+}
+
+func TestMemStatsCollectExtendedDisabled(t *testing.T) {


See my comments above!

srebhan · 2026-03-30T12:47:13Z

+
+	err := plugin.Init()
+	require.NoError(t, err)


Suggested change

err := plugin.Init()

require.NoError(t, err)

require.NoError(t, plugin.Init())

…test per review

srebhan

Thanks @pvlltvk! Please expand the expected metrics (see my comment) and also avoid testutil.MustMetric as this will be gone soon.

srebhan · 2026-04-16T17:00:12Z

+	require.NoError(t, plugin.Gather(&acc))
+
+	expected := []telegraf.Metric{
+		testutil.MustMetric("mem", map[string]string{}, map[string]interface{}{


Please use

Suggested change

testutil.MustMetric("mem", map[string]string{}, map[string]interface{}{

metric.New(

"mem",

map[string]string{},

map[string]interface{}{

srebhan · 2026-04-16T17:00:27Z

+			"phys_avail":        uint64(0),
+			"page_file_total":   uint64(0),
+			"page_file_avail":   uint64(0),
+		}, time.Unix(0, 0), telegraf.Gauge),


Suggested change

}, time.Unix(0, 0), telegraf.Gauge),

},

time.Unix(0, 0), telegraf.Gauge),

srebhan · 2026-04-16T17:04:04Z

+			extendedFields: map[string]interface{}{
+				"active_anon":   uint64(5765169152),
+				"inactive_anon": uint64(1082245120),
+				"active_file":   uint64(3535425536),
+				"inactive_file": uint64(4421992448),
+				"unevictable":   uint64(143360),
+				"percpu":        uint64(5767168),
+			},


Please use

Suggested change

extendedFields: map[string]interface{}{

"active_anon": uint64(5765169152),

"inactive_anon": uint64(1082245120),

"active_file": uint64(3535425536),

"inactive_file": uint64(4421992448),

"unevictable": uint64(143360),

"percpu": uint64(5767168),

},

extended: []telegraf.Metric{

metric.New(

"mem",

map[string]string{},

map[string]interface{}{

"total": uint64(12400),

"available": uint64(7600),

"used": uint64(5000),

"used_percent": 100 * float64(5000) / float64(12400),

"available_percent": 100 * float64(7600) / float64(12400),

"free": uint64(1235),

"active": uint64(0),

"buffered": uint64(0),

"cached": uint64(0),

"commit_limit": uint64(0),

"committed_as": uint64(0),

"dirty": uint64(0),

"high_free": uint64(0),

"high_total": uint64(0),

"huge_pages_free": uint64(0),

"huge_page_size": uint64(0),

"huge_pages_total": uint64(0),

"inactive": uint64(0),

"low_free": uint64(0),

"low_total": uint64(0),

"mapped": uint64(0),

"page_tables": uint64(0),

"shared": uint64(0),

"slab": uint64(0),

"sreclaimable": uint64(0),

"sunreclaim": uint64(0),

"swap_cached": uint64(0),

"swap_free": uint64(0),

"swap_total": uint64(0),

"vmalloc_chunk": uint64(0),

"vmalloc_total": uint64(0),

"vmalloc_used": uint64(0),

"write_back_tmp": uint64(0),

"write_back": uint64(0),

"active_anon": uint64(5765169152),

"inactive_anon": uint64(1082245120),

"active_file": uint64(3535425536),

"inactive_file": uint64(4421992448),

"unevictable": uint64(143360),

"percpu": uint64(5767168),

},

time.Unix(0, 0),

telegraf.Gauge,

),

},

and the same below.

Expand expected metrics and use metric.New instead of testutil.MustMetric

telegraf-tiger · 2026-04-17T20:05:31Z

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -1.69 % for linux amd64 (new size: 298.8 MB, nightly size 303.9 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB	. RPM	. TAR . GZ	. ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

srebhan

LGTM. Thanks @pvlltvk!

skartikey

@pvlltvk Thanks for the contribution!

telegraf-tiger Bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 15, 2026

srebhan reviewed Mar 20, 2026

View reviewed changes

Comment thread plugins/inputs/mem/mem_linux.go

Comment thread plugins/inputs/mem/mem.go

Comment thread plugins/inputs/mem/mem_test.go Outdated

srebhan self-assigned this Mar 20, 2026

pvlltvk force-pushed the mem-extended-stats branch from 008ce25 to 51ca14c Compare March 27, 2026 19:39

feat(inputs.mem): fix tests

e4a5090

srebhan reviewed Mar 30, 2026

View reviewed changes

pvlltvk added 2 commits April 9, 2026 22:37

feat(inputs.mem): Add Windows extended stats test and refactor Linux …

9035c7d

…test per review

feat(inputs.mem): Fix Windows test

7364fcd

srebhan reviewed Apr 16, 2026

View reviewed changes

feat(inputs.mem): improve tests

0167532

Expand expected metrics and use metric.New instead of testutil.MustMetric

srebhan approved these changes Apr 22, 2026

View reviewed changes

srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 22, 2026

srebhan assigned skartikey and unassigned srebhan Apr 22, 2026

skartikey approved these changes Apr 24, 2026

View reviewed changes

skartikey merged commit d378008 into influxdata:master Apr 24, 2026
27 checks passed

github-actions Bot added this to the v1.39.0 milestone Apr 24, 2026

skartikey mentioned this pull request Apr 24, 2026

chore(inputs.mem): Clean up extended memory follow-up nits #18791

Merged

2 tasks

azure-monitor-assistant Bot mentioned this pull request Jun 10, 2026

Upgrade telegraf-agent to 1.39.0 microsoft/Docker-Provider#1713

Merged

	}, time.Unix(0, 0), telegraf.Gauge),
	},
	time.Unix(0, 0), telegraf.Gauge),

-			extendedFields: map[string]interface{}{
-				"active_anon":   uint64(5765169152),
-				"inactive_anon": uint64(1082245120),
-				"active_file":   uint64(3535425536),
-				"inactive_file": uint64(4421992448),
-				"unevictable":   uint64(143360),
-				"percpu":        uint64(5767168),
-			},
+			extended: 	[]telegraf.Metric{
+				metric.New(
+					"mem",
+					map[string]string{},
+					map[string]interface{}{
+						"total":             uint64(12400),
+						"available":         uint64(7600),
+						"used":              uint64(5000),
+						"used_percent":      100 * float64(5000) / float64(12400),
+						"available_percent": 100 * float64(7600) / float64(12400),
+						"free":              uint64(1235),
+						"active":            uint64(0),
+						"buffered":          uint64(0),
+						"cached":            uint64(0),
+						"commit_limit":      uint64(0),
+						"committed_as":      uint64(0),
+						"dirty":             uint64(0),
+						"high_free":         uint64(0),
+						"high_total":        uint64(0),
+						"huge_pages_free":   uint64(0),
+						"huge_page_size":    uint64(0),
+						"huge_pages_total":  uint64(0),
+						"inactive":          uint64(0),
+						"low_free":          uint64(0),
+						"low_total":         uint64(0),
+						"mapped":            uint64(0),
+						"page_tables":       uint64(0),
+						"shared":            uint64(0),
+						"slab":              uint64(0),
+						"sreclaimable":      uint64(0),
+						"sunreclaim":        uint64(0),
+						"swap_cached":       uint64(0),
+						"swap_free":         uint64(0),
+						"swap_total":        uint64(0),
+						"vmalloc_chunk":     uint64(0),
+						"vmalloc_total":     uint64(0),
+						"vmalloc_used":      uint64(0),
+						"write_back_tmp":    uint64(0),
+						"write_back":        uint64(0),
+						"active_anon":   uint64(5765169152),
+						"inactive_anon": uint64(1082245120),
+						"active_file":   uint64(3535425536),
+						"inactive_file": uint64(4421992448),
+						"unevictable":   uint64(143360),
+						"percpu":        uint64(5767168),
+					},
+					time.Unix(0, 0),
+					telegraf.Gauge,
+				),
+			},

Uh oh!

Conversation

pvlltvk commented Mar 15, 2026

Summary

Checklist

Related issues

Uh oh!

srebhan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

srebhan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

srebhan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

telegraf-tiger Bot commented Apr 17, 2026

Artifact URLs

Uh oh!

srebhan left a comment

Choose a reason for hiding this comment

Uh oh!

skartikey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants