feat(inputs.nvidia_smi): Add schema v13 support#18690
Open
lbatalha wants to merge 2 commits intoinfluxdata:masterfrom
Open
feat(inputs.nvidia_smi): Add schema v13 support#18690lbatalha wants to merge 2 commits intoinfluxdata:masterfrom
lbatalha wants to merge 2 commits intoinfluxdata:masterfrom
Conversation
srebhan
requested changes
Apr 17, 2026
Member
srebhan
left a comment
There was a problem hiding this comment.
Thanks for your contribution @lbatalha!
You are doing way too much in this PR and you should split it into at least three ones
- cleaning up existing code without any change in functionality
- fix issue in existing code around the set-if-used functions (if any)
- add support for schema v13
This makes PRs easier to review and allows us to pin-point behavior changes to a certain commit of issues appear...
Author
|
Oh good point, I will clean up this PR to contain only the schema v13 changes for now. |
Support nvsmi_device_v13.dtd from driver version 580+. Includes new schema_v13 package and v13 test case (without setter refactor).
Author
|
I have removed all changes that are not relevant to adding v13 support. |
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for nvsmi_device_v13.dtd schema.
I do not have a GPU capable of reporting ECC stats so I was unable to fully test that feature, though the two fields that do have values are reported correctly.
Checklist
Related issues
resolves #17482
based on #18176