Skip to content

feat(inputs.nvidia_smi): Add schema v13 support#18690

Open
lbatalha wants to merge 2 commits intoinfluxdata:masterfrom
lbatalha:master
Open

feat(inputs.nvidia_smi): Add schema v13 support#18690
lbatalha wants to merge 2 commits intoinfluxdata:masterfrom
lbatalha:master

Conversation

@lbatalha
Copy link
Copy Markdown

@lbatalha lbatalha commented Apr 10, 2026

Summary

This adds support for nvsmi_device_v13.dtd schema.

I do not have a GPU capable of reporting ECC stats so I was unable to fully test that feature, though the two fields that do have values are reported correctly.

Checklist

Related issues

resolves #17482
based on #18176

@telegraf-tiger telegraf-tiger Bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 10, 2026
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @lbatalha!

You are doing way too much in this PR and you should split it into at least three ones

  • cleaning up existing code without any change in functionality
  • fix issue in existing code around the set-if-used functions (if any)
  • add support for schema v13

This makes PRs easier to review and allows us to pin-point behavior changes to a certain commit of issues appear...

Comment thread plugins/inputs/nvidia_smi/common/setters.go Outdated
@srebhan srebhan self-assigned this Apr 17, 2026
@srebhan srebhan changed the title feat(nvidia_smi): add NVIDIA v13 schema support feat(inputs.nvidia_smi): add NVIDIA v13 schema support Apr 17, 2026
@telegraf-tiger telegraf-tiger Bot added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Apr 17, 2026
@lbatalha
Copy link
Copy Markdown
Author

Oh good point, I will clean up this PR to contain only the schema v13 changes for now.

Support nvsmi_device_v13.dtd from driver version 580+. Includes new schema_v13 package and v13 test case (without setter refactor).
@lbatalha
Copy link
Copy Markdown
Author

I have removed all changes that are not relevant to adding v13 support.

@telegraf-tiger
Copy link
Copy Markdown
Contributor

@lbatalha lbatalha requested a review from srebhan April 17, 2026 19:01
@srebhan srebhan changed the title feat(inputs.nvidia_smi): add NVIDIA v13 schema support feat(inputs.nvidia_smi): Add schema v13 support Apr 22, 2026
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lbatalha! Code looks good. Looking forward to reviewing PRs for the other two issues you mentioned. ;-)

@srebhan srebhan added area/nvidia ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Apr 22, 2026
@srebhan srebhan assigned skartikey and unassigned srebhan Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/nvidia feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[inputs.nvidia_smi] Unknown schema version "v13", using latest know schema for parsing

3 participants