Skip to content

Add support for vacation and holidays#1233

Draft
make-github-pseudonymous-again wants to merge 31 commits into
mainfrom
feat-schedule-time-off-1
Draft

Add support for vacation and holidays#1233
make-github-pseudonymous-again wants to merge 31 commits into
mainfrom
feat-schedule-time-off-1

Conversation

@make-github-pseudonymous-again
Copy link
Copy Markdown
Contributor

@make-github-pseudonymous-again make-github-pseudonymous-again commented May 14, 2025

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2025

Codecov Report

❌ Patch coverage is 51.86567% with 129 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.29%. Comparing base (d99cb6e) to head (c4809aa).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...ports/ui/appointments/EventSchedulingDialogTab.tsx 7.14% 26 Missing ⚠️
...rts/ui/appointments/TimeOffSchedulingDialogTab.tsx 7.14% 26 Missing ⚠️
imports/ui/calendar/EventFragment.tsx 37.83% 22 Missing and 1 partial ⚠️
imports/ui/consultations/ConsultationsOfTheDay.tsx 0.00% 21 Missing ⚠️
imports/ui/calendar/CalendarData.tsx 82.19% 4 Missing and 9 partials ⚠️
imports/ui/appointments/SlotPicker.tsx 8.33% 11 Missing ⚠️
imports/ui/appointments/useDateTimePickerState.ts 80.64% 4 Missing and 2 partials ⚠️
imports/ui/appointments/AppointmentDialog.tsx 92.30% 1 Missing ⚠️
imports/ui/calendar/ReactiveWeeklyCalendar.tsx 80.00% 1 Missing ⚠️
imports/ui/hooks/eventSubscription.ts 83.33% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (51.86%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   80.63%   80.29%   -0.35%     
==========================================
  Files         844      849       +5     
  Lines       14739    14876     +137     
  Branches     1978     2005      +27     
==========================================
+ Hits        11885    11944      +59     
- Misses       2325     2398      +73     
- Partials      529      534       +5     
Flag Coverage Δ
client 63.57% <51.86%> (-0.19%) ⬇️
server 49.56% <14.04%> (-0.28%) ⬇️
test 77.90% <16.52%> (-0.50%) ⬇️
test-app 61.77% <51.86%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Leveraging `globalThis` is necessary because the server does not know
about `window`.
This avoids relying on array indices as keys.
Any performance issues originating from the duplicate `useDateFormat`
calls can be resolved by deduplicating cached callbacks via contexts.
This only works well with `skipIdle` and `minEventDuration` set and
sufficiently large `maxLines`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature/agenda This issue is about the agenda functionality feature/appointments This issue is about the appointments functionality

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Use configured schedule to split /calendar/day consultation list instead of hard-coded AM/PM split Add support for vacation and holidays

1 participant