Quote complex vars correctly.

Author: tobyclemson

src/infrablocks/invoke_terraform/terraform/terraform.py

@@ -118,7 +118,10 @@ def _format_configuration_value(
         elif value is None:
             return f'{option_key}="{key}=null"'
         else:
-            return f'{option_key}="{key}={json.dumps(value)}"'
+            jsonified_value = (
+                json.dumps(value).replace("\\", "\\\\").replace('"', r"\"")
+            )
+            return f'{option_key}="{key}={jsonified_value}"'
 
     def _build_backend_config(
         self, backend_config: BackendConfig | None

tests/unit/infrablocks/invoke_terraform/terraform/test_terraform.py

@@ -204,7 +204,12 @@ def test_apply_executes_with_list_of_string_var(self):
         terraform.apply(vars=variables)
 
         executor.execute.assert_called_once_with(
-            ["terraform", "apply", '-var="foo=["ex", "why", "zed"]"'], env=None
+            [
+                "terraform",
+                "apply",
+                '-var="foo=[\\"ex\\", \\"why\\", \\"zed\\"]"',
+            ],
+            env=None,
         )
 
     def test_apply_executes_with_list_of_integer_var(self):
@@ -259,7 +264,12 @@ def test_apply_executes_with_mapping_of_string_var(self):
         terraform.apply(vars=variables)
 
         executor.execute.assert_called_once_with(
-            ["terraform", "apply", '-var="foo={"a": "x", "b": "y"}"'], env=None
+            [
+                "terraform",
+                "apply",
+                '-var="foo={\\"a\\": \\"x\\", \\"b\\": \\"y\\"}"',
+            ],
+            env=None,
         )
 
     def test_apply_executes_with_mapping_of_integer_var(self):
@@ -270,7 +280,8 @@ def test_apply_executes_with_mapping_of_integer_var(self):
         terraform.apply(vars=variables)
 
         executor.execute.assert_called_once_with(
-            ["terraform", "apply", '-var="foo={"a": 1, "b": 2}"'], env=None
+            ["terraform", "apply", '-var="foo={\\"a\\": 1, \\"b\\": 2}"'],
+            env=None,
         )
 
     def test_apply_executes_with_mapping_of_float_var(self):
@@ -281,7 +292,8 @@ def test_apply_executes_with_mapping_of_float_var(self):
         terraform.apply(vars=variables)
 
         executor.execute.assert_called_once_with(
-            ["terraform", "apply", '-var="foo={"a": 1.1, "b": 2.2}"'], env=None
+            ["terraform", "apply", '-var="foo={\\"a\\": 1.1, \\"b\\": 2.2}"'],
+            env=None,
         )
 
     def test_apply_executes_with_mapping_of_boolean_var(self):
@@ -292,7 +304,11 @@ def test_apply_executes_with_mapping_of_boolean_var(self):
         terraform.apply(vars=variables)
 
         executor.execute.assert_called_once_with(
-            ["terraform", "apply", '-var="foo={"a": true, "b": false}"'],
+            [
+                "terraform",
+                "apply",
+                '-var="foo={\\"a\\": true, \\"b\\": false}"',
+            ],
             env=None,
         )
 
@@ -304,7 +320,11 @@ def test_apply_executes_with_mapping_of_none_var(self):
         terraform.apply(vars=variables)
 
         executor.execute.assert_called_once_with(
-            ["terraform", "apply", '-var="foo={"a": true, "b": false}"'],
+            [
+                "terraform",
+                "apply",
+                '-var="foo={\\"a\\": true, \\"b\\": false}"',
+            ],
             env=None,
         )