-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate pipeline from CircleCI to GitHub Actions #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| name: Main | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| # Every run publishes to RubyGems; serialise so close-together merges cannot | ||
| # race on version numbers. queue: max keeps every queued run (the default | ||
| # keeps only the newest pending), so a slow release approval delays later | ||
| # prereleases instead of cancelling them. | ||
| concurrency: | ||
| group: main | ||
| cancel-in-progress: false | ||
| queue: max | ||
|
|
||
| jobs: | ||
| skip-ci-check: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| should_skip_ci: ${{ steps.skip_ci_check.outputs.should_skip_ci }} | ||
| steps: | ||
| - id: skip_ci_check | ||
| env: | ||
| HEAD_COMMIT_MESSAGE: ${{ github.event.head_commit.message }} | ||
| run: | | ||
| if [[ "$HEAD_COMMIT_MESSAGE" == *"[no ci]"* ]] \ | ||
| || [[ "$HEAD_COMMIT_MESSAGE" == *"[skip ci]"* ]] \ | ||
| || [[ "$HEAD_COMMIT_MESSAGE" == *"[ci skip]"* ]]; then | ||
| echo "should_skip_ci=true" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "should_skip_ci=false" >> "$GITHUB_OUTPUT" | ||
| fi | ||
|
|
||
| check: | ||
| needs: [skip-ci-check] | ||
| if: needs.skip-ci-check.outputs.should_skip_ci != 'true' | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Install tools | ||
| uses: infrablocks/github-actions/asdf_install@v1 | ||
| - name: Check | ||
| run: ./go library:check | ||
| - name: Notify Slack | ||
| if: ${{ !cancelled() }} | ||
| continue-on-error: true | ||
| run: ./go "slack:notify[${{ job.status }}]" | ||
| env: | ||
| SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }} | ||
|
|
||
| test: | ||
| needs: [skip-ci-check] | ||
| if: needs.skip-ci-check.outputs.should_skip_ci != 'true' | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Install tools | ||
| uses: infrablocks/github-actions/asdf_install@v1 | ||
| - name: Test | ||
| run: ./go test:unit | ||
| - name: Notify Slack | ||
| if: ${{ !cancelled() }} | ||
| continue-on-error: true | ||
| run: ./go "slack:notify[${{ job.status }}]" | ||
| env: | ||
| SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }} | ||
|
|
||
| prerelease: | ||
| needs: [check, test] | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
| permissions: | ||
| contents: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Install tools | ||
| uses: infrablocks/github-actions/asdf_install@v1 | ||
| - name: Install secrets tools | ||
| run: sudo apt-get update && sudo apt-get install -y git-crypt gnupg | ||
| - name: Unlock git-crypt | ||
| run: ./go git_crypt:unlock_with_encrypted_gpg_key | ||
| env: | ||
| ENCRYPTION_PASSPHRASE: ${{ secrets.ENCRYPTION_PASSPHRASE }} | ||
| - name: Configure RubyGems credentials | ||
| run: | | ||
| mkdir -p ~/.gem | ||
| cp config/secrets/rubygems/credentials ~/.gem/credentials | ||
| chmod 0600 ~/.gem/credentials | ||
| - name: Set CI git author | ||
| run: ./go repository:set_ci_author | ||
| - name: Prerelease | ||
| run: ./go "version:bump[pre]" && ./go release | ||
| - name: Push release commit | ||
| run: git push && git push --tags | ||
| - name: Notify Slack of release hold | ||
| continue-on-error: true | ||
| run: ./go "slack:notify[success,on_hold]" | ||
| env: | ||
| SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }} | ||
| - name: Notify Slack | ||
| if: ${{ !cancelled() }} | ||
| continue-on-error: true | ||
| run: ./go "slack:notify[${{ job.status }}]" | ||
| env: | ||
| SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }} | ||
|
|
||
| release: | ||
| needs: [prerelease] | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
| environment: release | ||
| permissions: | ||
| contents: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: main | ||
| - name: Pull latest main | ||
| # Approval can land long after the run starts; release publishes main | ||
| # as of approval time, not the tested SHA — parity with the old | ||
| # release.sh, which also pulled. prerelease.sh never pulled, so the | ||
| # prerelease job deliberately has no pull. | ||
| run: git pull | ||
| - name: Install tools | ||
| uses: infrablocks/github-actions/asdf_install@v1 | ||
| - name: Install secrets tools | ||
| run: sudo apt-get update && sudo apt-get install -y git-crypt gnupg | ||
| - name: Unlock git-crypt | ||
| run: ./go git_crypt:unlock_with_encrypted_gpg_key | ||
| env: | ||
| ENCRYPTION_PASSPHRASE: ${{ secrets.ENCRYPTION_PASSPHRASE }} | ||
| - name: Configure RubyGems credentials | ||
| run: | | ||
| mkdir -p ~/.gem | ||
| cp config/secrets/rubygems/credentials ~/.gem/credentials | ||
| chmod 0600 ~/.gem/credentials | ||
| - name: Set CI git author | ||
| run: ./go repository:set_ci_author | ||
| - name: Release | ||
| run: ./go "version:bump[minor]" && ./go release | ||
| - name: Push release commit | ||
| run: git push && git push --tags | ||
| - name: Notify Slack | ||
| if: ${{ !cancelled() }} | ||
| continue-on-error: true | ||
| run: ./go "slack:notify[${{ job.status }}]" | ||
| env: | ||
| SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }} | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Plan concern — not a defect of this diff.
The
concurrencymapping only acceptsgroupandcancel-in-progress;queueis not part of the GitHub Actions schema, and the "keeps every queued run" guarantee the comment describes is not achievable via native concurrency (at most one running + one pending per group). Depending on parser strictness the key is either silently ignored (serialisation viagroupstill works; lossless queuing does not) or rejected.This YAML is reproduced verbatim from the family plan's authoritative §4.2 block (plan lines 292–295), so the diff is plan-conformant and this is not an implementation defect. Flagging it as the highest-value item for a human to correct in the plan before fleet-wide rollout: drop
queue: maxand reword the comment, or implement lossless queuing outside native concurrency.