Skip to content

Migrate pipeline from CircleCI to GitHub Actions #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phelma merged 2 commits into from
Jul 23, 2026
Merged

Migrate pipeline from CircleCI to GitHub Actions #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54e947f
migrate pipeline from circleci to github actions
phelma Jul 22, 2026
91898fb
use test:unit rake task in ci workflows
phelma Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
183 changes: 0 additions & 183 deletions .circleci/config.yml
View file
Open in desktop

This file was deleted.

0 .circleci/gpg.private.enc → .github/gpg.private.enc
View file
Open in desktop
File renamed without changes.
135 changes: 135 additions & 0 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
name: Main
on:
push:
branches:
- main

permissions:
contents: read

jobs:
check:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@v4
- name: Install tools
uses: infrablocks/github-actions/asdf_install@v1
- name: Check
run: ./go library:check
- name: Notify Slack
if: ${{ !cancelled() }}
continue-on-error: true
run: ./go "slack:notify[${{ job.status }}]"
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}

test:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@v4
- name: Install tools
uses: infrablocks/github-actions/asdf_install@v1
- name: Test
run: ./go test:unit
- name: Notify Slack
if: ${{ !cancelled() }}
continue-on-error: true
run: ./go "slack:notify[${{ job.status }}]"
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}

prerelease:
needs: [check, test]
runs-on: ubuntu-latest
timeout-minutes: 30
# Job-level group (here and on release): a run awaiting release approval
# holds the slot, and a workflow-level group would freeze all main CI for
# the approval window. queue: max keeps every queued run; the default
# cancels all but the newest.
concurrency:
group: main
cancel-in-progress: false
queue: max

@phelma phelma Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Standards (minor) — plan concern

concurrency.queue: max is a newer Actions key not present in the sibling rake_slack workflows; if the runner's schema does not honour it, the queue-all-runs intent silently degrades.

The plan §4.2 specifies this key verbatim and cites the 2026-05-07 GA changelog, so it is authoritative here — noted only so a human can confirm the feature is live for this org.

@phelma phelma Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Plan concern (not a defect) — queue: max.

Recording for a human: the correctness and safety lenses flag queue: max as an unsupported GitHub Actions concurrency key (only group / cancel-in-progress are historically valid). However, plan §4.2 specifies queue: max verbatim and cites a GA feature dated 2026-05-07. Treated as documented-deliberate and not counted as a defect — but worth confirming the feature shipped as cited, since otherwise intermediate prerelease runs may be silently coalesced.

permissions:
contents: write
steps:
- uses: actions/checkout@v4
- name: Install tools
uses: infrablocks/github-actions/asdf_install@v1
- name: Install secrets tools
run: ./scripts/ci/common/install-git-crypt.sh
- name: Unlock git-crypt
run: ./go git_crypt:unlock_with_encrypted_gpg_key
env:
ENCRYPTION_PASSPHRASE: ${{ secrets.ENCRYPTION_PASSPHRASE }}
- name: Configure RubyGems credentials
run: ./scripts/ci/common/configure-rubygems.sh
- name: Set CI git author
run: ./go repository:set_ci_author
- name: Bump version
run: ./go "version:bump[pre]"
- name: Release
run: ./go release
- name: Push commits
run: git push
- name: Push tags
run: git push --tags
- name: Notify Slack of release hold
continue-on-error: true
run: ./go "slack:notify[success,on_hold]"
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
- name: Notify Slack
if: ${{ !cancelled() }}
continue-on-error: true
run: ./go "slack:notify[${{ job.status }}]"
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}

release:
needs: [prerelease]
runs-on: ubuntu-latest
timeout-minutes: 30
environment: release
concurrency:
group: main
cancel-in-progress: false
queue: max
permissions:
contents: write
steps:
- uses: actions/checkout@v4
with:
ref: main
- name: Pull latest main
# Publishes main as of approval time, not the SHA that triggered the
# run; --ff-only so a non-fast-forward fails loudly
run: git pull --ff-only
- name: Install tools
uses: infrablocks/github-actions/asdf_install@v1
- name: Install secrets tools
run: ./scripts/ci/common/install-git-crypt.sh
- name: Unlock git-crypt
run: ./go git_crypt:unlock_with_encrypted_gpg_key
env:
ENCRYPTION_PASSPHRASE: ${{ secrets.ENCRYPTION_PASSPHRASE }}
- name: Configure RubyGems credentials
run: ./scripts/ci/common/configure-rubygems.sh
- name: Set CI git author
run: ./go repository:set_ci_author
- name: Bump version
run: ./go "version:bump[minor]"
- name: Release

@phelma phelma Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Safety (minor) — plan concern

./go release (gem release --tag --push) publishes to RubyGems before the Push commits/Push tags steps. A push failure leaves a public, effectively unyankable version while main never records the bump — the next run recomputes the same version and gem push fails on a duplicate, wedging releases.

This is a pre-existing, deliberately-preserved hazard inside the untouched ./go release logic (§1, D5). No change required in this migration.

run: ./go release

@phelma phelma Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Correctness / plan-conformance (critical) — Release job runs a non-existent documentation:update task.

This step runs ./go documentation:update, but there is no documentation:update task anywhere in the Rakefile or the loaded gems, and the deleted scripts/ci/steps/release.sh only ran version:bump[minor] + release — it never ran documentation generation. Plan §4.2 is explicit: "include the whole Update documentation step only if the repo's release.sh runs it; omit the step otherwise." This repo's release.sh does not, so the step must be removed. As written, every release run fails here with Don't know how to build task 'documentation:update'.

Fix: delete the Update documentation step from the release job.

@phelma phelma Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is false, ./go documentation:update does not exist.

- name: Push commits
run: git push
- name: Push tags
run: git push --tags
- name: Notify Slack
if: ${{ !cancelled() }}
continue-on-error: true
run: ./go "slack:notify[${{ job.status }}]"
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
Loading
Loading