Improve fask failure detection for ingest and retrieve

task files

Author: ayefimov-1

roles/telemetry_chargeback/tasks/gen_synth_loki_data.yml

@@ -35,9 +35,3 @@
   when: not file_preexists.stat.exists | bool
   changed_when: cloudkitty_synth_totals_file_output.rc == 0
   any_errors_fatal: true
-
-## validating changes
-- name: "Load synthetic metrics summary for {{ scenario_name }}"
-  ansible.builtin.include_vars:
-    file: "{{ cloudkitty_synth_totals_file }}"
-    name: synth_data_rates

roles/telemetry_chargeback/tasks/ingest_loki_data.yml

@@ -1,23 +1,33 @@
 ---
 # Ingest data generated by gen_synth_loki_data.yml to Loki
 
-- name: "TEST Push data to Loki"
-  ansible.builtin.uri:
-    ## loki_push_url will be used in future role developement
-    url: "{{ loki_push_url }}"
-    method: POST
-    src: "{{ cloudkitty_data_file }}"
-    body_format: json
-    client_cert: "{{ cert_dir }}/tls.crt"
-    client_key: "{{ cert_dir }}/tls.key"
-    validate_certs: false
-    status_code: 204
-    return_content: true
-  register: loki_response
-  ignore_errors: true
-  failed_when: loki_response.status != 204
+- name: "Push data to Loki {{ scenario_name }}"
+  block:
+    - name: "POST data to Loki"
+      ansible.builtin.uri:
+        # loki_push_url is configured in setup_loki_env.yml
+        url: "{{ loki_push_url }}"
+        method: POST
+        src: "{{ cloudkitty_data_file }}"
+        body_format: json
+        client_cert: "{{ cert_dir }}/tls.crt"
+        client_key: "{{ cert_dir }}/tls.key"
+        # Note: ca_path not required with validate_certs: false, but included for consistency with retrieve_loki_data.yml
+        ca_path: "{{ cert_dir }}/ca.crt"
+        validate_certs: false
+        status_code: 204
+        return_content: true
+      register: loki_response
 
-- name: "Ingest Status Message"
-  ansible.builtin.debug:
-    msg: "Ingestion Successful"
-  when: loki_response.status | default(0) == 204
+    - name: "Ingest Status Message"
+      ansible.builtin.debug:
+        msg: "Ingestion Successful for {{ scenario_name }}"
+
+  rescue:
+    - name: "IngestionFailed"
+      ansible.builtin.fail:
+        msg:
+          - "Scenario: {{ scenario_name }}"
+          - "Status: {{ loki_response.status | default('Unknown') }}"
+          - "Body: {{ loki_response.content | default('No Content') }}"
+          - "Message: {{ loki_response.msg | default('Request failed') }}"

roles/telemetry_chargeback/tasks/load_loki_data.yml

@@ -4,6 +4,3 @@
 
 - name: "Flush data to Loki storage for {{ scenario_name }}"
   ansible.builtin.include_tasks: flush_loki_data.yml
-
-- name: "Retrieve data log from Loki for {{ scenario_name }}"
-  ansible.builtin.include_tasks: retrieve_loki_data.yml