Skip to content

[telemetry_chargeback] add the ability to pass test scenario names via extra-vars#389

Merged
elfiesmelfie merged 7 commits into
masterfrom
alexy_ck_job_6a
Jun 4, 2026
Merged

[telemetry_chargeback] add the ability to pass test scenario names via extra-vars#389
elfiesmelfie merged 7 commits into
masterfrom
alexy_ck_job_6a

Conversation

@ayefimov-1
Copy link
Copy Markdown
Contributor

@ayefimov-1 ayefimov-1 commented May 27, 2026 •
edited
Loading

Implemented the ability to pass test scenario names via extra-vars

  • Add cloudkitty_test_scenarios variable which will allow for extra-vars override
  • Set default value for cloudkitty_test_scenarios list (Default test scenarios)
  • Removed self discovery of test Scenarios from main.yml
  • README. md updated only with test scenario list changes. Other doc changes will be added later.

Authored-by: @myadla
Co-authored-by: @ayefimov-1
AI Assisted by: Claude

@ayefimov-1 ayefimov-1 marked this pull request as draft May 27, 2026 13:17
@ayefimov-1 ayefimov-1 changed the base branch from master to alexy_ck_job_6 May 27, 2026 18:05
@ayefimov-1 ayefimov-1 requested review from danpawlik and elfiesmelfie and removed request for danpawlik May 27, 2026 21:52
@ayefimov-1 ayefimov-1 changed the base branch from alexy_ck_job_6 to master May 28, 2026 11:58
@ayefimov-1 ayefimov-1 force-pushed the alexy_ck_job_6a branch 2 times, most recently from 5bb27cc to 1d38ff7 Compare May 28, 2026 20:06
@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented May 28, 2026

Tested with extra vars set: https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/build/f0bed16fc32842c3adb4a463fcd2a72d

elfiesmelfie
elfiesmelfie requested changes May 29, 2026
View reviewed changes
Comment thread roles/telemetry_chargeback/defaults/main.yml
Comment thread roles/telemetry_chargeback/tasks/main.yml Outdated
elfiesmelfie
elfiesmelfie reviewed May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@elfiesmelfie elfiesmelfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the REDME updates in this PR, since the documentation is very useful for reviewing

ayefimov-1 added 3 commits May 29, 2026 10:44
@ayefimov-1
[telemetry_chargeback] add the ability to pass test scenario names vi…
9f6bf86 
…a extra-vars

- if cloudkitty_test_scenarios is a non empty list then it will define scenarios being run
- else default list will be run
@ayefimov-1
Testing extra-vars parameter
4411d39
@ayefimov-1
set cloudkitty_test_scenarios back to empty list
457734a
@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented May 29, 2026

Please include the REDME updates in this PR, since the documentation is very useful for reviewing

Done

@ayefimov-1 ayefimov-1 requested a review from elfiesmelfie May 29, 2026 17:55
@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented May 31, 2026

Recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented Jun 1, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/9f30ec272fd74ce88d824d0cca0277da

✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 32m 17s
✔️ functional-chargeback-tests-osp18 SUCCESS in 1h 39m 21s
✔️ feature-verification-tests-noop SUCCESS in 1m 23s
❌ functional-tests-osp18 POST_FAILURE in 2h 12m 46s

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented Jun 1, 2026

Recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented Jun 1, 2026

This change depends on a change that failed to merge.

Change #375 is needed.

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented Jun 1, 2026

recheck

1 similar comment
@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented Jun 1, 2026

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented Jun 1, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/15f02cc5b86a4f4fa62bfaa17c4dbd0c

✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 28m 18s
✔️ functional-chargeback-tests-osp18 SUCCESS in 1h 23m 19s
❌ feature-verification-tests-noop NODE_FAILURE Node(set) request 100-0000108732 failed in 0s
✔️ functional-tests-osp18 SUCCESS in 2h 12m 43s

@fserucas
Copy link
Copy Markdown

fserucas commented Jun 2, 2026

recheck

@ayefimov-1 ayefimov-1 marked this pull request as ready for review June 3, 2026 16:51
elfiesmelfie
elfiesmelfie requested changes Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@elfiesmelfie elfiesmelfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very easy to follow, and looks good to me except for the two nits that I pointed out with the docs. IMHO it's not necessary to specify that the cloudkitty_test_scenarios var can be overridden via extra-vars. It can be overwritten via a lot of mechanisms (role defaults are the second lowest precedence). extra-vars are the highest precedence, and override everything else.

Comment thread roles/telemetry_chargeback/README.md Outdated
Comment thread roles/telemetry_chargeback/README.md Outdated
@elfiesmelfie
Remove the unneeded documentation comments about variable precedence
e51f8c4 
Co-authored-by: Emma Foley <elfiesmelfie@users.noreply.github.com>
@elfiesmelfie elfiesmelfie enabled auto-merge (squash) June 4, 2026 12:46
@elfiesmelfie elfiesmelfie merged commit 1936df5 into master Jun 4, 2026
11 checks passed
@elfiesmelfie elfiesmelfie deleted the alexy_ck_job_6a branch June 4, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elfiesmelfie elfiesmelfie elfiesmelfie approved these changes

@lnatapov lnatapov lnatapov approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ayefimov-1 @fserucas @elfiesmelfie @lnatapov