v8.0.1 is a breaking change

[lumirlumir]

Hi,

It seems v8.0.1 is a breaking change: parse5 v8.0.1 now depends on entities v8.0.0, which requires Node >= 20.19.0, whereas entities v6.0.0 required Node >= 0.12 according to its changelog. This is effectively a breaking change since a transitive dependency now requires a higher Node version.

parse5 related PR: #1713
entities related release: https://github.com/fb55/entities/releases/tag/v8.0.0
entities related PR: https://github.com/fb55/entities/pull/2183/changes#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

[43081j]

What exactly inside entities needs Node 20?

parse5 is already ESM only, requiring Node 20 if you're using CJS, but supporting older Node if you're using ESM yourself.

Have you observed that it doesn't run in node 18 now but did before?

Absolutely possible I missed something but we need to know it actually requires 20, rather than just being a precaution because it went ESM only

[43081j]

ok i did some digging.

entities@8 basically uses atob which is in node since Node 16 - making the actual minimum node theoretically 16.x based on that.

that pretty much aligns with what i thought our minimum supported Node was (as of 8.0.0), but we haven't defined it in package.json.

If we haven't observed any breaks, i think we're all good. have you seen a project using 8.x actually break because of this?