Merge pull request firecrawl#3461 from firecrawl/devin/1777532537-fix-ruby-sdk-qa-issues

fix(ruby-sdk): unwrap credit_usage data field and default skipTlsVerification to false

Author: Chadha93

apps/ruby-sdk/lib/firecrawl/client.rb

@@ -372,7 +372,8 @@ def get_concurrency
     # @return [Models::CreditUsage]
     def get_credit_usage
       raw = @http.get("/v2/team/credit-usage")
-      Models::CreditUsage.new(raw)
+      data = raw["data"] || raw
+      Models::CreditUsage.new(data)
     end
 
     private

apps/ruby-sdk/lib/firecrawl/models/scrape_options.rb

@@ -15,7 +15,7 @@ class ScrapeOptions
 
       def initialize(**kwargs)
         FIELDS.each { |f| instance_variable_set(:"@#{f}", kwargs[f]) }
-        @skip_tls_verification = true if @skip_tls_verification.nil?
+        @skip_tls_verification = false if @skip_tls_verification.nil?
       end
 
       def to_h

apps/ruby-sdk/lib/firecrawl/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Firecrawl
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

apps/ruby-sdk/test/firecrawl/client_test.rb

@@ -370,7 +370,7 @@ def test_get_credit_usage
     stub_request(:get, "#{BASE_URL}/v2/team/credit-usage")
       .to_return(
         status: 200,
-        body: JSON.generate(remainingCredits: 500, planCredits: 1000),
+        body: JSON.generate(success: true, data: { remainingCredits: 500, planCredits: 1000 }),
         headers: { "Content-Type" => "application/json" }
       )
 
@@ -454,14 +454,14 @@ def test_scrape_options_to_h
     assert_equal 1000, h["waitFor"]
     assert_equal false, h["mobile"]
     assert_equal "stealth", h["proxy"]
-    assert_equal true, h["skipTlsVerification"] # defaults to true
+    assert_equal false, h["skipTlsVerification"] # defaults to false
     refute h.key?("timeout") # nil values should be omitted
   end
 
-  def test_scrape_options_skip_tls_defaults_to_true
+  def test_scrape_options_skip_tls_defaults_to_false
     opts = Firecrawl::Models::ScrapeOptions.new
-    assert_equal true, opts.skip_tls_verification
-    assert_equal true, opts.to_h["skipTlsVerification"]
+    assert_equal false, opts.skip_tls_verification
+    assert_equal false, opts.to_h["skipTlsVerification"]
   end
 
   def test_scrape_options_skip_tls_can_be_overridden_to_false
@@ -530,7 +530,7 @@ def test_batch_scrape_options_to_h
       zero_data_retention: true
     )
     h = opts.to_h
-    assert_equal({ "formats" => ["markdown"], "skipTlsVerification" => true }, h["options"])
+    assert_equal({ "formats" => ["markdown"], "skipTlsVerification" => false }, h["options"])
     assert_equal 5, h["maxConcurrency"]
     assert_equal true, h["zeroDataRetention"]
   end