Skip to content

Commit 9293920

Browse files
authored
fix(python-sdk): map min_age to minAge in scrape options (firecrawl#4002)
1 parent 47f321f commit 9293920

3 files changed

Lines changed: 25 additions & 1 deletion

File tree

apps/python-sdk/firecrawl/__tests__/unit/v2/methods/test_parse_request_preparation.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,3 +87,16 @@ def test_prepare_parse_request_strips_lockdown(self):
8787

8888
payload = json.loads(fields["options"])
8989
assert "lockdown" not in payload
90+
91+
def test_prepare_parse_request_strips_min_age(self):
92+
options = ParseOptions(formats=["markdown"], min_age=1000)
93+
fields, _ = _prepare_parse_request(
94+
b"<html><body><h1>Parse</h1></body></html>",
95+
options,
96+
filename="upload.html",
97+
content_type="text/html",
98+
)
99+
100+
payload = json.loads(fields["options"])
101+
assert "minAge" not in payload
102+
assert "min_age" not in payload

apps/python-sdk/firecrawl/__tests__/unit/v2/utils/test_validation.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,4 +387,14 @@ def test_prepare_parsers_max_pages_model(self):
387387

388388
result = prepare_scrape_options(options)
389389

390-
assert result["parsers"][0]["maxPages"] == 5
390+
assert result["parsers"][0]["maxPages"] == 5
391+
392+
def test_prepare_min_age_maps_to_camel_case(self):
393+
"""min_age must be sent as minAge; the server drops the snake_case key."""
394+
options = ScrapeOptions(min_age=1000, max_age=5000)
395+
396+
result = prepare_scrape_options(options)
397+
398+
assert result["minAge"] == 1000
399+
assert "min_age" not in result
400+
assert result["maxAge"] == 5000

apps/python-sdk/firecrawl/v2/utils/validation.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -566,6 +566,7 @@ def prepare_scrape_options(options: Optional[ScrapeOptions]) -> Optional[Dict[st
566566
"block_ads": "blockAds",
567567
"store_in_cache": "storeInCache",
568568
"max_age": "maxAge",
569+
"min_age": "minAge",
569570
"redact_pii": "redactPII",
570571
"threat_protection": "threatProtection",
571572
}

0 commit comments

Comments
 (0)