[pull] main from firecrawl:main#323
Merged
Merged
Conversation
autumn/client.ts runs once at module import, so the missingKeyWarned boolean could never guard a second invocation. Dropped the flag and kept the single missing-key warning. Co-authored-by: firecrawl-spring[bot] <254786068+firecrawl-spring[bot]@users.noreply.github.com> Co-authored-by: micahstairs <micah@sideguide.dev>
De-duplicate constants that were declared identically in multiple files: - TOKENS_PER_CREDIT (was in usage.ts + v1/v2 token-usage controllers) is now exported once from services/autumn/usage.ts and imported by the two token-usage controllers (which already import getTeamBalance from there). - CREDITS_FEATURE_ID / TEAM_FEATURE_ID are now sourced from the canonical exports in autumn.service.ts (already the source for SEARCH_CREDITS_FEATURE_ID used by routes/record-options). usage.ts and the autumn-health admin controller import them instead of redeclaring. TEAM_FEATURE_ID is now exported. Behavior-preserving; no import cycles introduced. Co-authored-by: firecrawl-spring[bot] <254786068+firecrawl-spring[bot]@users.noreply.github.com> Co-authored-by: micahstairs <micah@sideguide.dev>
ExchangeTerms and ExchangeProvider are only used within exchange.ts (and via the resolveExchangeProvider/setExchangeProvidersForTest helpers in tests); the types themselves are never imported elsewhere, so knip flags the exports as unused. Drop the export keyword. No behavior change. Co-authored-by: firecrawl-spring[bot] <254786068+firecrawl-spring[bot]@users.noreply.github.com> Co-authored-by: micahstairs <micah@sideguide.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )