Enabling options watch so that if anything changes it will refresh countUp#2
Open
dougloyo wants to merge 1 commit intoinorganik:masterfrom
Open
Enabling options watch so that if anything changes it will refresh countUp#2dougloyo wants to merge 1 commit intoinorganik:masterfrom
dougloyo wants to merge 1 commit intoinorganik:masterfrom
Conversation
Owner
|
Looks good, you just need to build your changes with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request enables options change watch to trigger an update on the countUp instance if any property of the options object changes.
Use case: We needed to dynamically change the suffix part of the options. For example: if our number was a percentage "97%" and then we needed it to be a number "183.23" we needed to change the options.suffix value and have countUp update.
Additionally we cleaned up the options extend because generally speaking this is when your plugin or module has default options to be replaced with the ones being passed in.
For example:
if you had: var options={ someDefaultValue:5 }; inside of your module/plugin.
you would use extends to override that value.
$scope.options would probably be = { someDefaultValue:6, otherValue:10 }
angular.extend(options, $scope.options);
Please let me know if this makes sense.